From: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
To: Sameeh Jubran <sameeh@daynix.com>
Cc: qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>,
Dmitry Fleytman <dmitry@daynix.com>,
Yan Vugenfirer <yan@daynix.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] e1000: Fixing interrupts pace.
Date: Mon, 16 May 2016 13:55:48 +0300 [thread overview]
Message-ID: <20160516135548.7548d55b@pixies> (raw)
In-Reply-To: <CAKPgXcEa18DhRfqo0BHR0ZVn_aFfCxgrg5VjsCLiSSGkgf8=Tg@mail.gmail.com>
Hi,
On Mon, 16 May 2016 08:58:32 +0300, sameeh@daynix.com wrote:
> This means that on a real hardware when mit_delay==0 ( don't use the timer
> ) the Ethernet controller guarantees a maximum
> observable interrupt rate of 7813 interrupts/sec. Unfortunately that isn't
> the case in the emulated device and the interrupt
> rate bypass the rate of the real hardware which could lead to an interrupt
> storm. Setting mit_delay to 500 guarantees a maximum
> interrupt rate of 7813 interrupts/sec.
OK, if that is the case, then
> > > + mit_delay = (mit_delay < 500) ? 500 : mit_delay;
> > > +
> > > if (mit_delay) {
> > > s->mit_timer_on = 1;
> > > timer_mod(s->mit_timer,
The existing 'if (mit_delay)' is now superflous, since always true,
hence can be removed.
next prev parent reply other threads:[~2016-05-16 10:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 7:37 [Qemu-devel] [PATCH 0/2] e1000: Introducing an upper bound of interrupts Sameeh Jubran
2016-03-17 7:37 ` [Qemu-devel] [PATCH 1/2] e1000: Fixing interrupts pace Sameeh Jubran
2016-05-04 11:34 ` Shmulik Ladkani
2016-05-16 5:58 ` Sameeh Jubran
2016-05-16 10:55 ` Shmulik Ladkani [this message]
2016-05-17 18:26 ` Sameeh Jubran
2016-03-17 7:37 ` [Qemu-devel] [PATCH 2/2] Revert "e1000: fix hang of win2k12 shutdown with flood ping" Sameeh Jubran
2016-03-17 19:51 ` [Qemu-devel] [PATCH 0/2] e1000: Introducing an upper bound of interrupts Denis V. Lunev
2016-03-18 1:34 ` Jason Wang
2016-03-21 8:25 ` Sameeh Jubran
2016-03-22 11:23 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160516135548.7548d55b@pixies \
--to=shmulik.ladkani@ravellosystems.com \
--cc=dmitry@daynix.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sameeh@daynix.com \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).