From: Max Filippov <jcmvbkbc@gmail.com>
To: Sergey Fedorov <sergey.fedorov@linaro.org>
Cc: qemu-devel@nongnu.org,
"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Sergey Fedorov" <serge.fdrv@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] cpu-exec: Fix direct jump to TB spanning page
Date: Mon, 16 May 2016 17:43:35 +0300 [thread overview]
Message-ID: <20160516144335.GA31697@octofox.metropolis> (raw)
In-Reply-To: <1463404380-29302-1-git-send-email-sergey.fedorov@linaro.org>
On Mon, May 16, 2016 at 04:13:00PM +0300, Sergey Fedorov wrote:
> From: Sergey Fedorov <serge.fdrv@gmail.com>
>
> It is not safe to make a direct jump to a TB spanning two pages in
> system emulation because the mapping for the second page can get changed
> but we don't take care of direct jumps in this case.
>
> However in user mode emulation, this is not the case because there's
> only static address translation and TBs are always invalidated properly.
>
> Fixes: 5b053a4a2827 ("tcg: Clean up direct block chaining safety checks")
>
> Reported-by: Max Filippov <jcmvbkbc@gmail.com>
> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
> Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>
> ---
> cpu-exec.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
Tested-by: Max Filippov <jcmvbkbc@gmail.com>
--
Thanks.
-- Max
prev parent reply other threads:[~2016-05-16 14:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 13:13 [Qemu-devel] [PATCH] cpu-exec: Fix direct jump to TB spanning page Sergey Fedorov
2016-05-16 13:49 ` Richard Henderson
2016-05-16 14:36 ` Sergey Fedorov
2016-05-25 16:37 ` Sergey Fedorov
2016-05-26 12:52 ` Peter Maydell
2016-05-16 14:43 ` Max Filippov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160516144335.GA31697@octofox.metropolis \
--to=jcmvbkbc@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=crosthwaite.peter@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=serge.fdrv@gmail.com \
--cc=sergey.fedorov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).