From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58470)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1b2UwO-0001t6-PQ
	for qemu-devel@nongnu.org; Mon, 16 May 2016 22:41:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1b2UwL-0000AL-FY
	for qemu-devel@nongnu.org; Mon, 16 May 2016 22:41:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56873)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1b2UwL-0000AG-9j
	for qemu-devel@nongnu.org; Mon, 16 May 2016 22:40:57 -0400
Date: Tue, 17 May 2016 10:40:56 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160517024056.GB21731@ad.usersys.redhat.com>
References: <1462966873-30473-1-git-send-email-pbonzini@redhat.com>
	<1462966873-30473-3-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1462966873-30473-3-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] dma-helpers: change BlockBackend to
 opaque value in DMAIOFunc
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, hare@suse.de, vrozenfe@redhat.com

On Wed, 05/11 13:41, Paolo Bonzini wrote:
> diff --git a/include/sysemu/dma.h b/include/sysemu/dma.h
> index b0fbb9b..ddc4afc 100644
> --- a/include/sysemu/dma.h
> +++ b/include/sysemu/dma.h
> @@ -197,14 +197,15 @@ void qemu_sglist_add(QEMUSGList *qsg, dma_addr_t base, dma_addr_t len);
>  void qemu_sglist_destroy(QEMUSGList *qsg);
>  #endif
>  
> -typedef BlockAIOCB *DMAIOFunc(BlockBackend *blk, int64_t sector_num,
> +typedef BlockAIOCB *DMAIOFunc(int64_t sector_num,
>                                QEMUIOVector *iov, int nb_sectors,
> -                              BlockCompletionFunc *cb, void *opaque);
> +                              BlockCompletionFunc *cb, void *cb_opaque,
> +                              void *opaque);
>  

The patch itself looks good, but I'm wondering if it's time to introduce:

    typedef struct {
        BlockCompletionFunc *cb;
        void *opaque;
    } BlockCompletion;

for more readability in such cases.

Fam