From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-block@nongnu.org, mreitz@redhat.com, den@openvz.org,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Some more write_zeroes tests
Date: Wed, 18 May 2016 12:09:37 +0200 [thread overview]
Message-ID: <20160518100937.GC4820@noname.str.redhat.com> (raw)
In-Reply-To: <573B8085.4010706@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
Am 17.05.2016 um 22:35 hat Eric Blake geschrieben:
> No test of crossing a cluster boundary at this point? I would probably do:
>
> $QEMU_IO -c "write -z 27k 2k" "$TEST_IMG" | _filter_qemu_io
>
> then check that the map shows an allocation starting at 24k for 8192 bytes
> What you have looks fine, but again, I'd consider also testing a
> sub-cluster size 'write -z' that spans a cluster boundary, including the
> case where it is overwriting data from the backing file.
Okay, I'll put some more time into this test case. What we're testing
here is a source for corruption bugs, so it's probably worth doing it
right.
Kevin
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2016-05-18 10:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 16:51 [Qemu-devel] [PATCH 0/3] qcow2: write_zeroes corruption fixes and tests Kevin Wolf
2016-05-17 16:51 ` [Qemu-devel] [PATCH 1/3] qcow2: fix condition in is_zero_cluster Kevin Wolf
2016-05-17 17:25 ` Eric Blake
2016-05-17 16:51 ` [Qemu-devel] [PATCH 2/3] qcow2: Fix write_zeroes with partially allocated backing file cluster Kevin Wolf
2016-05-17 17:22 ` Eric Blake
2016-05-17 19:20 ` Denis V. Lunev
2016-05-17 16:51 ` [Qemu-devel] [PATCH 3/3] qemu-iotests: Some more write_zeroes tests Kevin Wolf
2016-05-17 20:35 ` Eric Blake
2016-05-18 10:09 ` Kevin Wolf [this message]
2016-05-18 12:27 ` [Qemu-devel] [PATCH v2 " Kevin Wolf
2016-05-18 14:12 ` Eric Blake
2016-05-18 14:22 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160518100937.GC4820@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).