From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2yQF-00089p-Ja for qemu-devel@nongnu.org; Wed, 18 May 2016 06:09:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2yQE-0007z0-LX for qemu-devel@nongnu.org; Wed, 18 May 2016 06:09:47 -0400 Date: Wed, 18 May 2016 12:09:37 +0200 From: Kevin Wolf Message-ID: <20160518100937.GC4820@noname.str.redhat.com> References: <1463503863-19009-1-git-send-email-kwolf@redhat.com> <1463503863-19009-4-git-send-email-kwolf@redhat.com> <573B8085.4010706@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3V7upXqbjpZ4EhLz" Content-Disposition: inline In-Reply-To: <573B8085.4010706@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Some more write_zeroes tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-block@nongnu.org, mreitz@redhat.com, den@openvz.org, qemu-devel@nongnu.org --3V7upXqbjpZ4EhLz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 17.05.2016 um 22:35 hat Eric Blake geschrieben: > No test of crossing a cluster boundary at this point? I would probably d= o: >=20 > $QEMU_IO -c "write -z 27k 2k" "$TEST_IMG" | _filter_qemu_io >=20 > then check that the map shows an allocation starting at 24k for 8192 bytes > What you have looks fine, but again, I'd consider also testing a > sub-cluster size 'write -z' that spans a cluster boundary, including the > case where it is overwriting data from the backing file. Okay, I'll put some more time into this test case. What we're testing here is a source for corruption bugs, so it's probably worth doing it right. Kevin --3V7upXqbjpZ4EhLz Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJXPD9hAAoJEH8JsnLIjy/WMtsP/j+JoStqbnu1POkqMEXE8KZH XjLo0Zp+fxbGW3VCC0jKit55QXNfkCQ2e/HpbClxIIaHcKmXFm678VN+h49+3hYW 3Vqrz2kcJrc4YpuMZsum2E5TQmOEH0TPvR6J36Yg959NmWsVJk6txbg4SnMT2ee7 Xi+VQhXawWw3JmNex3wQQ2x9ZZBhHmO4mAoygweBwzLbaPQWGUrShzopv+rw4UIM HpnuBlq3fvz+8fVuq5zzy9qDw5zNNoKNw88N2p30WwkWypGp+8TNGTxfbd3c4cOH VaQ0Mm/yb8US6l75C1EcUyIHyhwR4cr33f388/iE0UwkOH7rn/LJiCPnhx7AkbbK /Omun+AI1IA9mPlGSCaB29jz0veBA90XQp7tzBGbg5A3KaAJXtxRbN5+3HGVl5mv YwgNkVKh6cTsuvqRykEGuioXw+8WCm+B2fYY6acz6/yUvNZQdLcI+PlICaTkeRbQ Z5y7aUPIFyvHer9H+8/wSejUnCIatAir0jMWBP9ZnHcwXfRO520FMwqZuqYerdRE M/uWfccoph6gpG2nPZo/9C9/5lJY3Y5WU5ogfcrkNbEPA04XypAVeArvz41ybNhZ MEVCobM1B3i0B0hEyEEe9Tb2tchkgAvIzibS+uPYPa7D5BJnZHotBvWOacEQjx1+ My/aNhfzCNwL87+V4Y8o =DhC6 -----END PGP SIGNATURE----- --3V7upXqbjpZ4EhLz--