From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3CF2-0001d9-G4 for qemu-devel@nongnu.org; Wed, 18 May 2016 20:55:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3CF0-00070q-HO for qemu-devel@nongnu.org; Wed, 18 May 2016 20:55:07 -0400 Date: Thu, 19 May 2016 08:54:59 +0800 From: Fam Zheng Message-ID: <20160519005459.GA31140@ad.usersys.redhat.com> References: <1463550807-2750-1-git-send-email-famz@redhat.com> <573C7B74.3000706@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <573C7B74.3000706@redhat.com> Subject: Re: [Qemu-devel] [PATCH] backup: Fail early if cannot determine cluster size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Kevin Wolf , qemu-block@nongnu.org, Jeff Cody , qemu-stable@nongnu.org, Max Reitz , jsnow@redhat.com On Wed, 05/18 08:25, Eric Blake wrote: > On 05/17/2016 11:53 PM, Fam Zheng wrote: > > Otherwise the job is orphaned and block_job_cancel_sync in > > bdrv_close_all() when quiting will hang. > > s/quiting/quitting/ > > > > > A simple reproducer is running blockdev-backup from null-co:// to > > null-co://. > > Worth a qemu-iotests addition? Sure, as you asked, will send one in addition. Fam > > > > > Cc: qemu-stable@nongnu.org > > Signed-off-by: Fam Zheng > > --- > > block/backup.c | 34 ++++++++++++++++++---------------- > > 1 file changed, 18 insertions(+), 16 deletions(-) > > > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >