From: Fam Zheng <famz@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-block@nongnu.org, armbru@redhat.com, qemu-devel@nongnu.org,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/1] block: clarify error message for qmp-eject
Date: Thu, 19 May 2016 09:24:04 +0800 [thread overview]
Message-ID: <20160519012404.GB31140@ad.usersys.redhat.com> (raw)
In-Reply-To: <1463608420-26837-2-git-send-email-jsnow@redhat.com>
On Wed, 05/18 17:53, John Snow wrote:
> If you use HMP's eject but the CDROM tray is locked, you may get a
> confusing error message informing you that the "tray isn't open."
>
> As this is the point of eject, we can do a little better and help
> clarify that the tray was locked and that it (might) open up later,
> so try again.
>
> It's not ideal, but it makes the semantics of the (legacy) eject
> command more understandable to end users when they try to use it.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
Thanks for addressing my comments! And I like the new message a lot.
Reviewed-by: Fam Zheng <famz@redhat.com>
next prev parent reply other threads:[~2016-05-19 1:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 21:53 [Qemu-devel] [PATCH v2 0/1] block: clarify error message for qmp-eject John Snow
2016-05-18 21:53 ` [Qemu-devel] [PATCH v2 1/1] " John Snow
2016-05-18 22:05 ` Eric Blake
2016-05-19 1:24 ` Fam Zheng [this message]
2016-05-20 14:48 ` Markus Armbruster
2016-05-20 21:27 ` John Snow
2016-05-30 11:56 ` Markus Armbruster
2016-05-19 12:40 ` [Qemu-devel] [Qemu-block] [PATCH v2 0/1] " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160519012404.GB31140@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).