From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3ChB-0006Mn-67 for qemu-devel@nongnu.org; Wed, 18 May 2016 21:24:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3Ch9-0004Vc-7M for qemu-devel@nongnu.org; Wed, 18 May 2016 21:24:12 -0400 Date: Thu, 19 May 2016 09:24:04 +0800 From: Fam Zheng Message-ID: <20160519012404.GB31140@ad.usersys.redhat.com> References: <1463608420-26837-1-git-send-email-jsnow@redhat.com> <1463608420-26837-2-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463608420-26837-2-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 1/1] block: clarify error message for qmp-eject List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: qemu-block@nongnu.org, armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com On Wed, 05/18 17:53, John Snow wrote: > If you use HMP's eject but the CDROM tray is locked, you may get a > confusing error message informing you that the "tray isn't open." > > As this is the point of eject, we can do a little better and help > clarify that the tray was locked and that it (might) open up later, > so try again. > > It's not ideal, but it makes the semantics of the (legacy) eject > command more understandable to end users when they try to use it. > > Signed-off-by: John Snow Thanks for addressing my comments! And I like the new message a lot. Reviewed-by: Fam Zheng