From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47089)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1b3fX2-0000Y9-Ge
	for qemu-devel@nongnu.org; Fri, 20 May 2016 04:11:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1b3fWv-00027F-AN
	for qemu-devel@nongnu.org; Fri, 20 May 2016 04:11:39 -0400
Date: Fri, 20 May 2016 10:11:21 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20160520081121.GD4861@noname.redhat.com>
References: <1463731067-7120-1-git-send-email-kwolf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1463731067-7120-1-git-send-email-kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block: Fix memory leak in bdrv_next()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org

Am 20.05.2016 um 09:57 hat Kevin Wolf geschrieben:
> When all BDSes have already been iterated and we return NULL, the
> iterator must be freed, too.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

NACK, this doesn't fix cases where the caller exists loop prematurely.

Kevin