From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4nqH-0000Ma-Eg for qemu-devel@nongnu.org; Mon, 23 May 2016 07:16:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b4nqD-0005eu-5q for qemu-devel@nongnu.org; Mon, 23 May 2016 07:16:12 -0400 Received: from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f]:37040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4nqC-0005eh-Py for qemu-devel@nongnu.org; Mon, 23 May 2016 07:16:09 -0400 Received: by mail-wm0-x22f.google.com with SMTP id z87so43882115wmh.0 for ; Mon, 23 May 2016 04:16:08 -0700 (PDT) Date: Mon, 23 May 2016 14:16:04 +0300 From: Shmulik Ladkani Message-ID: <20160523141604.583694bf@pixies> In-Reply-To: <1464000485-27041-1-git-send-email-ppandit@redhat.com> References: <1464000485-27041-1-git-send-email-ppandit@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] scsi: pvscsi: check command descriptor ring buffer size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: P J P Cc: Qemu Developers , Dmitry Fleytman , Paolo Bonzini , Li Qiang , Idan Brown , Prasad J Pandit Hi, On Mon, 23 May 2016 16:18:05 +0530, ppandit@redhat.com wrote: > From: Prasad J Pandit > > Vmware Paravirtual SCSI emulation uses command descriptors to > process SCSI commands. These descriptors come with their ring > buffers. A guest could set the ring buffer size to an arbitrary > value leading to OOB access issue. Add check to avoid it. > > Reported-by: Li Qiang > Signed-off-by: Prasad J Pandit Reviewed-by: Shmulik Ladkani