[Qemu-devel] [PATCH v7] block: Move BlockRequest type to io.c

[Qemu-devel] [PATCH v7] block: Move BlockRequest type to io.c

[Eric Blake]

I was thrown by the fact that the public type BlockRequest had
an anonymous union, but no obvious discriminator.  Turns out
that the only client of the second branch of the union was code
internal to io.c, now that commit 91c6e4b killed public
multiwrite, so move it into io.c and improve the comments.

Signed-off-by: Eric Blake <eblake@redhat.com>
---
v7: new title, keep anonymous union but move struct's location
v6 was here:
https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg00562.html

 include/block/block.h | 21 ---------------------
 block/io.c            | 21 +++++++++++++++++++++
 2 files changed, 21 insertions(+), 21 deletions(-)

diff --git a/include/block/block.h b/include/block/block.h
index a8c15e3..a8fc458 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -329,27 +329,6 @@ BlockAIOCB *bdrv_aio_discard(BlockDriverState *bs,
 void bdrv_aio_cancel(BlockAIOCB *acb);
 void bdrv_aio_cancel_async(BlockAIOCB *acb);

-typedef struct BlockRequest {
-    /* Fields to be filled by caller */
-    union {
-        struct {
-            int64_t sector;
-            int nb_sectors;
-            int flags;
-            QEMUIOVector *qiov;
-        };
-        struct {
-            int req;
-            void *buf;
-        };
-    };
-    BlockCompletionFunc *cb;
-    void *opaque;
-
-    /* Filled by block layer */
-    int error;
-} BlockRequest;
-
 /* sg packet commands */
 int bdrv_ioctl(BlockDriverState *bs, unsigned long int req, void *buf);
 BlockAIOCB *bdrv_aio_ioctl(BlockDriverState *bs,
diff --git a/block/io.c b/block/io.c
index 60a6bd8..e3d35c7 100644
--- a/block/io.c
+++ b/block/io.c
@@ -1908,6 +1908,27 @@ void bdrv_aio_cancel_async(BlockAIOCB *acb)
 /**************************************************************/
 /* async block device emulation */

+typedef struct BlockRequest {
+    union {
+        /* Used during read, write, trim */
+        struct {
+            int64_t sector;
+            int nb_sectors;
+            int flags;
+            QEMUIOVector *qiov;
+        };
+        /* Used during ioctl */
+        struct {
+            int req;
+            void *buf;
+        };
+    };
+    BlockCompletionFunc *cb;
+    void *opaque;
+
+    int error;
+} BlockRequest;
+
 typedef struct BlockAIOCBCoroutine {
     BlockAIOCB common;
     BlockRequest req;
-- 
2.5.5

Re: [Qemu-devel] [PATCH v7] block: Move BlockRequest type to io.c

[Fam Zheng]

On Thu, 05/19 17:05, Eric Blake wrote:
> I was thrown by the fact that the public type BlockRequest had
> an anonymous union, but no obvious discriminator.  Turns out
> that the only client of the second branch of the union was code
> internal to io.c, now that commit 91c6e4b killed public
> multiwrite, so move it into io.c and improve the comments.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>

Thanks, applied to my block branch:

https://github.com/famz/qemu/tree/block