[Qemu-devel] [PULL 0/1] rng: rename RndRandom to RngRandom

[Qemu-devel] [PULL 0/1] rng: rename RndRandom to RngRandom

[Amit Shah]

The following changes since commit 65603e2fc18b48e6e55a3dd693669413141694ec:

  tci: do not include exec/exec-all.h (2016-05-20 15:07:46 +0100)

are available in the git repository at:

  https://git.kernel.org/pub/scm/virt/qemu/amit/virtio-rng.git tags/rng-2.7-1

for you to fetch changes up to cde63615343fb241f4044e6471e6e25be78574c8:

  rng-random: rename RndRandom to RngRandom (2016-05-23 12:18:43 +0530)

----------------------------------------------------------------
rng: rename RndRandom to RndRandom

----------------------------------------------------------------

Wei Jiangang (1):
  rng-random: rename RndRandom to RngRandom

 backends/rng-random.c          | 18 +++++++++---------
 include/hw/virtio/virtio-rng.h |  2 +-
 include/sysemu/rng-random.h    |  4 ++--
 3 files changed, 12 insertions(+), 12 deletions(-)

-- 
2.5.5

[Qemu-devel] [PULL 1/1] rng-random: rename RndRandom to RngRandom

[Amit Shah]

From: Wei Jiangang <weijg.fnst@cn.fujitsu.com>

Usually, Random Number Generator is abbreviated to RNG/rng.
so replacing RndRandom with RngRandom seems more reasonable
and keep consistent with RngBackend.

Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
Reviewed-by: Pankaj Gupta <pagupta@redhat.com>
Message-Id: <1460684168-5403-1-git-send-email-weijg.fnst@cn.fujitsu.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
 backends/rng-random.c          | 18 +++++++++---------
 include/hw/virtio/virtio-rng.h |  2 +-
 include/sysemu/rng-random.h    |  4 ++--
 3 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/backends/rng-random.c b/backends/rng-random.c
index 2e44e25..e2a49b0 100644
--- a/backends/rng-random.c
+++ b/backends/rng-random.c
@@ -17,7 +17,7 @@
 #include "qapi/qmp/qerror.h"
 #include "qemu/main-loop.h"
 
-struct RndRandom
+struct RngRandom
 {
     RngBackend parent;
 
@@ -34,7 +34,7 @@ struct RndRandom
 
 static void entropy_available(void *opaque)
 {
-    RndRandom *s = RNG_RANDOM(opaque);
+    RngRandom *s = RNG_RANDOM(opaque);
 
     while (!QSIMPLEQ_EMPTY(&s->parent.requests)) {
         RngRequest *req = QSIMPLEQ_FIRST(&s->parent.requests);
@@ -57,7 +57,7 @@ static void entropy_available(void *opaque)
 
 static void rng_random_request_entropy(RngBackend *b, RngRequest *req)
 {
-    RndRandom *s = RNG_RANDOM(b);
+    RngRandom *s = RNG_RANDOM(b);
 
     if (QSIMPLEQ_EMPTY(&s->parent.requests)) {
         /* If there are no pending requests yet, we need to
@@ -68,7 +68,7 @@ static void rng_random_request_entropy(RngBackend *b, RngRequest *req)
 
 static void rng_random_opened(RngBackend *b, Error **errp)
 {
-    RndRandom *s = RNG_RANDOM(b);
+    RngRandom *s = RNG_RANDOM(b);
 
     if (s->filename == NULL) {
         error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
@@ -83,7 +83,7 @@ static void rng_random_opened(RngBackend *b, Error **errp)
 
 static char *rng_random_get_filename(Object *obj, Error **errp)
 {
-    RndRandom *s = RNG_RANDOM(obj);
+    RngRandom *s = RNG_RANDOM(obj);
 
     return g_strdup(s->filename);
 }
@@ -92,7 +92,7 @@ static void rng_random_set_filename(Object *obj, const char *filename,
                                  Error **errp)
 {
     RngBackend *b = RNG_BACKEND(obj);
-    RndRandom *s = RNG_RANDOM(obj);
+    RngRandom *s = RNG_RANDOM(obj);
 
     if (b->opened) {
         error_setg(errp, QERR_PERMISSION_DENIED);
@@ -105,7 +105,7 @@ static void rng_random_set_filename(Object *obj, const char *filename,
 
 static void rng_random_init(Object *obj)
 {
-    RndRandom *s = RNG_RANDOM(obj);
+    RngRandom *s = RNG_RANDOM(obj);
 
     object_property_add_str(obj, "filename",
                             rng_random_get_filename,
@@ -118,7 +118,7 @@ static void rng_random_init(Object *obj)
 
 static void rng_random_finalize(Object *obj)
 {
-    RndRandom *s = RNG_RANDOM(obj);
+    RngRandom *s = RNG_RANDOM(obj);
 
     if (s->fd != -1) {
         qemu_set_fd_handler(s->fd, NULL, NULL, NULL);
@@ -139,7 +139,7 @@ static void rng_random_class_init(ObjectClass *klass, void *data)
 static const TypeInfo rng_random_info = {
     .name = TYPE_RNG_RANDOM,
     .parent = TYPE_RNG_BACKEND,
-    .instance_size = sizeof(RndRandom),
+    .instance_size = sizeof(RngRandom),
     .class_init = rng_random_class_init,
     .instance_init = rng_random_init,
     .instance_finalize = rng_random_finalize,
diff --git a/include/hw/virtio/virtio-rng.h b/include/hw/virtio/virtio-rng.h
index 3f07de7..2bc1ee5 100644
--- a/include/hw/virtio/virtio-rng.h
+++ b/include/hw/virtio/virtio-rng.h
@@ -26,7 +26,7 @@ struct VirtIORNGConf {
     RngBackend *rng;
     uint64_t max_bytes;
     uint32_t period_ms;
-    RndRandom *default_backend;
+    RngRandom *default_backend;
 };
 
 typedef struct VirtIORNG {
diff --git a/include/sysemu/rng-random.h b/include/sysemu/rng-random.h
index 4332772..38186fe 100644
--- a/include/sysemu/rng-random.h
+++ b/include/sysemu/rng-random.h
@@ -15,8 +15,8 @@
 #include "qom/object.h"
 
 #define TYPE_RNG_RANDOM "rng-random"
-#define RNG_RANDOM(obj) OBJECT_CHECK(RndRandom, (obj), TYPE_RNG_RANDOM)
+#define RNG_RANDOM(obj) OBJECT_CHECK(RngRandom, (obj), TYPE_RNG_RANDOM)
 
-typedef struct RndRandom RndRandom;
+typedef struct RngRandom RngRandom;
 
 #endif
-- 
2.5.5

Re: [Qemu-devel] [PULL 0/1] rng: rename RndRandom to RngRandom

[Peter Maydell]

On 23 May 2016 at 16:50, Amit Shah <amit.shah@redhat.com> wrote:
> The following changes since commit 65603e2fc18b48e6e55a3dd693669413141694ec:
>
>   tci: do not include exec/exec-all.h (2016-05-20 15:07:46 +0100)
>
> are available in the git repository at:
>
>   https://git.kernel.org/pub/scm/virt/qemu/amit/virtio-rng.git tags/rng-2.7-1
>
> for you to fetch changes up to cde63615343fb241f4044e6471e6e25be78574c8:
>
>   rng-random: rename RndRandom to RngRandom (2016-05-23 12:18:43 +0530)
>
> ----------------------------------------------------------------
> rng: rename RndRandom to RndRandom

The gpg key used to sign this tag does not match the one I have
on record for you...

thanks
-- PMM

Re: [Qemu-devel] [PULL 0/1] rng: rename RndRandom to RngRandom

[Amit Shah]

[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]

On (Mon) 23 May 2016 [17:36:13], Peter Maydell wrote:
> On 23 May 2016 at 16:50, Amit Shah <amit.shah@redhat.com> wrote:
> > The following changes since commit 65603e2fc18b48e6e55a3dd693669413141694ec:
> >
> >   tci: do not include exec/exec-all.h (2016-05-20 15:07:46 +0100)
> >
> > are available in the git repository at:
> >
> >   https://git.kernel.org/pub/scm/virt/qemu/amit/virtio-rng.git tags/rng-2.7-1
> >
> > for you to fetch changes up to cde63615343fb241f4044e6471e6e25be78574c8:
> >
> >   rng-random: rename RndRandom to RngRandom (2016-05-23 12:18:43 +0530)
> >
> > ----------------------------------------------------------------
> > rng: rename RndRandom to RndRandom
> 
> The gpg key used to sign this tag does not match the one I have
> on record for you...

Right - I'm using a subkey of the key you've signed.  I created this
new subkey and placed it on a yubikey.

https://pgp.mit.edu/pks/lookup?op=vindex&search=0x1E9A3B5F854083B6

Signing this message using the key you've signed, and placing the
fingerprint of the new one here; hope that's sufficient verification.

sub   rsa4096/657EF670 2016-04-01 [S]
      Key fingerprint = CC63 D332 AB8F 4617 4529  6534 EB0B 4DFC 657E
      F670


		Amit

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [Qemu-devel] [PULL 0/1] rng: rename RndRandom to RngRandom

[Peter Maydell]

On 24 May 2016 at 03:25, Amit Shah <amit.shah@redhat.com> wrote:
> On (Mon) 23 May 2016 [17:36:13], Peter Maydell wrote:
>> On 23 May 2016 at 16:50, Amit Shah <amit.shah@redhat.com> wrote:
>> > The following changes since commit 65603e2fc18b48e6e55a3dd693669413141694ec:
>> >
>> >   tci: do not include exec/exec-all.h (2016-05-20 15:07:46 +0100)
>> >
>> > are available in the git repository at:
>> >
>> >   https://git.kernel.org/pub/scm/virt/qemu/amit/virtio-rng.git tags/rng-2.7-1
>> >
>> > for you to fetch changes up to cde63615343fb241f4044e6471e6e25be78574c8:
>> >
>> >   rng-random: rename RndRandom to RngRandom (2016-05-23 12:18:43 +0530)
>> >
>> > ----------------------------------------------------------------
>> > rng: rename RndRandom to RndRandom
>>
>> The gpg key used to sign this tag does not match the one I have
>> on record for you...
>
> Right - I'm using a subkey of the key you've signed.  I created this
> new subkey and placed it on a yubikey.
>
> https://pgp.mit.edu/pks/lookup?op=vindex&search=0x1E9A3B5F854083B6
>
> Signing this message using the key you've signed, and placing the
> fingerprint of the new one here; hope that's sufficient verification.
>
> sub   rsa4096/657EF670 2016-04-01 [S]
>       Key fingerprint = CC63 D332 AB8F 4617 4529  6534 EB0B 4DFC 657E
>       F670

I couldn't get this email to verify, but gpg automatically certifies
subkeys, so I just needed to refresh my copy of your master key,
which then includes a builtin signature that confirms that the
subkey is a part of it.

thanks
-- PMM

Re: [Qemu-devel] [PULL 0/1] rng: rename RndRandom to RngRandom

[Peter Maydell]

On 23 May 2016 at 16:50, Amit Shah <amit.shah@redhat.com> wrote:
> The following changes since commit 65603e2fc18b48e6e55a3dd693669413141694ec:
>
>   tci: do not include exec/exec-all.h (2016-05-20 15:07:46 +0100)
>
> are available in the git repository at:
>
>   https://git.kernel.org/pub/scm/virt/qemu/amit/virtio-rng.git tags/rng-2.7-1
>
> for you to fetch changes up to cde63615343fb241f4044e6471e6e25be78574c8:
>
>   rng-random: rename RndRandom to RngRandom (2016-05-23 12:18:43 +0530)
>
> ----------------------------------------------------------------
> rng: rename RndRandom to RndRandom
>
> ----------------------------------------------------------------

Applied, thanks.

-- PMM

Re: [Qemu-devel] [PULL 0/1] rng: rename RndRandom to RngRandom

[Amit Shah]

On (Tue) 24 May 2016 [11:42:12], Peter Maydell wrote:
> On 24 May 2016 at 03:25, Amit Shah <amit.shah@redhat.com> wrote:
> > On (Mon) 23 May 2016 [17:36:13], Peter Maydell wrote:
> >> On 23 May 2016 at 16:50, Amit Shah <amit.shah@redhat.com> wrote:
> >> > The following changes since commit 65603e2fc18b48e6e55a3dd693669413141694ec:
> >> >
> >> >   tci: do not include exec/exec-all.h (2016-05-20 15:07:46 +0100)
> >> >
> >> > are available in the git repository at:
> >> >
> >> >   https://git.kernel.org/pub/scm/virt/qemu/amit/virtio-rng.git tags/rng-2.7-1
> >> >
> >> > for you to fetch changes up to cde63615343fb241f4044e6471e6e25be78574c8:
> >> >
> >> >   rng-random: rename RndRandom to RngRandom (2016-05-23 12:18:43 +0530)
> >> >
> >> > ----------------------------------------------------------------
> >> > rng: rename RndRandom to RndRandom
> >>
> >> The gpg key used to sign this tag does not match the one I have
> >> on record for you...
> >
> > Right - I'm using a subkey of the key you've signed.  I created this
> > new subkey and placed it on a yubikey.
> >
> > https://pgp.mit.edu/pks/lookup?op=vindex&search=0x1E9A3B5F854083B6
> >
> > Signing this message using the key you've signed, and placing the
> > fingerprint of the new one here; hope that's sufficient verification.
> >
> > sub   rsa4096/657EF670 2016-04-01 [S]
> >       Key fingerprint = CC63 D332 AB8F 4617 4529  6534 EB0B 4DFC 657E
> >       F670
> 
> I couldn't get this email to verify,

Hm, wonder what went wrong..

> but gpg automatically certifies
> subkeys, so I just needed to refresh my copy of your master key,
> which then includes a builtin signature that confirms that the
> subkey is a part of it.

.. but this is resolved, so I'll leave the email signing experiment
for another day.

Thanks,

		Amit