From: "Emilio G. Cota" <cota@braap.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
MTTCG Devel <mttcg@listserver.greensocs.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Sergey Fedorov <serge.fdrv@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] atomics: do not use __atomic primitives for RCU atomics
Date: Tue, 24 May 2016 14:42:28 -0400 [thread overview]
Message-ID: <20160524184228.GA16037@flamenco> (raw)
In-Reply-To: <8737pah6bo.fsf@linaro.org>
On Sun, May 22, 2016 at 08:58:51 +0100, Alex Bennée wrote:
> For tsan runs you need to re-build with:
>
> ./configure --cc=gcc --extra-cflags="-pie -fPIE -fsanitize=thread" --with-coroutine=gthread
>
> Specifically the coroutine ucontext messing really confuses TSAN.
With your configure args + the appended I can at least compile
arm-softmmu, but I still get:
FATAL: ThreadSanitizer: unexpected memory mapping 0x55d9f389d000-0x55d9f4111000
Am I missing something? Thanks,
Emilio
diff --git a/configure b/configure
index ab54f3c..a8903fe 100755
--- a/configure
+++ b/configure
@@ -112,7 +112,7 @@ compile_object() {
compile_prog() {
local_cflags="$1"
- local_ldflags="$2"
+ local_ldflags="$2 -ltsan"
do_cc $QEMU_CFLAGS $local_cflags -o $TMPE $TMPC $LDFLAGS $local_ldflags
}
@@ -174,12 +174,12 @@ audio_drv_list=""
block_drv_rw_whitelist=""
block_drv_ro_whitelist=""
host_cc="cc"
-libs_softmmu=""
-libs_tools=""
+libs_softmmu="-ltsan"
+libs_tools="-ltsan"
audio_pt_int=""
audio_win_int=""
cc_i386=i386-pc-linux-gnu-gcc
-libs_qga=""
+libs_qga="-ltsan"
debug_info="yes"
stack_protector=""
next prev parent reply other threads:[~2016-05-24 18:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-21 20:42 [Qemu-devel] [PATCH 0/2] atomics: fix small RCU perf. regression + update documentation Emilio G. Cota
2016-05-21 20:42 ` [Qemu-devel] [PATCH 1/2] atomics: do not use __atomic primitives for RCU atomics Emilio G. Cota
2016-05-22 7:58 ` Alex Bennée
2016-05-24 18:42 ` Emilio G. Cota [this message]
2016-05-23 14:21 ` Paolo Bonzini
2016-05-23 15:55 ` Emilio G. Cota
2016-05-23 16:53 ` Richard Henderson
2016-05-23 17:09 ` Emilio G. Cota
2016-05-24 7:08 ` Paolo Bonzini
2016-05-24 19:56 ` Emilio G. Cota
2016-05-24 19:59 ` Sergey Fedorov
2016-05-25 8:52 ` Alex Bennée
2016-05-25 11:02 ` Sergey Fedorov
2016-05-21 20:42 ` [Qemu-devel] [PATCH 2/2] docs/atomics: update atomic_read/set comparison with Linux Emilio G. Cota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160524184228.GA16037@flamenco \
--to=cota@braap.org \
--cc=alex.bennee@linaro.org \
--cc=mttcg@listserver.greensocs.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=serge.fdrv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).