From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5NdD-0006Ql-SC for qemu-devel@nongnu.org; Tue, 24 May 2016 21:29:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5NdA-0002qx-GE for qemu-devel@nongnu.org; Tue, 24 May 2016 21:29:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5NdA-0002qr-AT for qemu-devel@nongnu.org; Tue, 24 May 2016 21:29:04 -0400 Date: Wed, 25 May 2016 09:29:03 +0800 From: Fam Zheng Message-ID: <20160525012903.GA23910@ad.usersys.redhat.com> References: <1458900629-2334-1-git-send-email-famz@redhat.com> <1458900629-2334-3-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 2/2] memory: Drop FlatRange.romd_mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: qemu-devel@nongnu.org, Paolo Bonzini , Drew Jones , Ard Biesheuvel , Peter Maydell On Tue, 05/24 19:47, Laszlo Ersek wrote: > Which I think satisfies (a->mr == b->mr), but falsifies (a->romd_mode == > b->romd_mode). > > In effect, the patch seems to allow merging and equality between FlatRange > objects when they only differ in romd_mode, and that's wrong. > > Given that the cover letter for this series says "memory: Dead code > removals", I'm requesting that this patch be simply reverted. Yes, it is a mistake, let's revert it. Thanks a lot for the analysis! Fam