From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5WZr-0003RX-RB for qemu-devel@nongnu.org; Wed, 25 May 2016 07:02:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5WZp-00030T-U6 for qemu-devel@nongnu.org; Wed, 25 May 2016 07:02:14 -0400 Date: Wed, 25 May 2016 13:02:00 +0200 From: Kevin Wolf Message-ID: <20160525110200.GC4815@noname.redhat.com> References: <1464128732-12667-1-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464128732-12667-1-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH 00/13] Kill sector-based write_zeroes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org Am 25.05.2016 um 00:25 hat Eric Blake geschrieben: > Kevin pointed out that my recent change to byte-based instead > of sector-based blk_write_zeroes() (commit 983a1600) makes life > harder as long as bdrv_write_zeroes is still sector-based, and > where the compiler doesn't flag any change in parameter types. > Complete the conversion, by renaming things (so the compiler > will help flag any future rebase conflicts), and making all > write_zeroes operations nominally take bytes. > > Definitely conflicts with Denis' qcow2_co_write_zeroes improvements > series, and probably with Kevin's conversion of block jobs to > BlockBackend. I can rebase if those land on the block branch first. I think I'll just pick up your patch 1 and include it in the next version of my series and then we can let git handle the question whose copy gets in. The rest of this series shouldn't conflict with mine. Kevin