From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53999)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1b5Wi9-0002k5-RF
	for qemu-devel@nongnu.org; Wed, 25 May 2016 07:10:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1b5Wi3-0004r4-RR
	for qemu-devel@nongnu.org; Wed, 25 May 2016 07:10:48 -0400
Date: Wed, 25 May 2016 13:10:32 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20160525111032.GD4815@noname.redhat.com>
References: <1464097654-12977-1-git-send-email-kwolf@redhat.com>
	<1464097654-12977-15-git-send-email-kwolf@redhat.com>
	<57454648.6020207@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <57454648.6020207@cn.fujitsu.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 14/14] blockjob: Remove BlockJob.bs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
Cc: qemu-block@nongnu.org, berto@igalia.com, jcody@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, jsnow@redhat.com

Am 25.05.2016 um 08:29 hat Changlong Xie geschrieben:
> On 05/24/2016 09:47 PM, Kevin Wolf wrote:
> >There is a single remaining user in qemu-img, which can be trivially
> >converted to using BlockJob.blk instead.
> >
> >Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> >Reviewed-by: Max Reitz <mreitz@redhat.com>
>=20
> Compiled with your block-jobs-bb branch:
>=20
> changlox ~/w/qemu/qemu% make check-unit -j8
> [...]
> tests/test-blockjob-txn.c: In function =E2=80=98test_block_job_complete=
=E2=80=99:
> tests/test-blockjob-txn.c:33:31: error: =E2=80=98BlockJob=E2=80=99 has =
no member named =E2=80=98bs=E2=80=99
>      BlockDriverState *bs =3D job->bs;

Thanks, will fix.

Kevin