From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60116)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1b5ZJT-0004JO-Fm
	for qemu-devel@nongnu.org; Wed, 25 May 2016 09:57:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1b5ZJS-0003jO-NV
	for qemu-devel@nongnu.org; Wed, 25 May 2016 09:57:31 -0400
Date: Wed, 25 May 2016 15:57:22 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20160525135722.GK4815@noname.redhat.com>
References: <1464128732-12667-1-git-send-email-eblake@redhat.com>
	<1464128732-12667-9-git-send-email-eblake@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1464128732-12667-9-git-send-email-eblake@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 08/13] gluster: Convert to
 bdrv_co_pwrite_zeroes()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Jeff Cody <jcody@redhat.com>, Max Reitz <mreitz@redhat.com>

Am 25.05.2016 um 00:25 hat Eric Blake geschrieben:
> Another step on our continuing quest to switch to byte-based
> interfaces.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  block/gluster.c | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/block/gluster.c b/block/gluster.c
> index a8aaacf..15aff4b 100644
> --- a/block/gluster.c
> +++ b/block/gluster.c
> @@ -454,14 +454,13 @@ static void qemu_gluster_reopen_abort(BDRVReopenState *state)
>  }
> 
>  #ifdef CONFIG_GLUSTERFS_ZEROFILL
> -static coroutine_fn int qemu_gluster_co_write_zeroes(BlockDriverState *bs,
> -        int64_t sector_num, int nb_sectors, BdrvRequestFlags flags)
> +static coroutine_fn int qemu_gluster_co_pwrite_zeroes(BlockDriverState *bs,
> +        int64_t offset, int count, BdrvRequestFlags flags)
>  {
>      int ret;
>      GlusterAIOCB acb;
>      BDRVGlusterState *s = bs->opaque;
> -    off_t size = nb_sectors * BDRV_SECTOR_SIZE;
> -    off_t offset = sector_num * BDRV_SECTOR_SIZE;
> +    off_t size = count;

This variable isn't really necessary. Up to you whether you want to
change it.

Reviewed-by: Kevin Wolf <kwolf@redhat.com>