From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38746) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5Zfh-0000f0-B9 for qemu-devel@nongnu.org; Wed, 25 May 2016 10:20:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5Zfg-0002V5-86 for qemu-devel@nongnu.org; Wed, 25 May 2016 10:20:29 -0400 Date: Wed, 25 May 2016 16:20:18 +0200 From: Kevin Wolf Message-ID: <20160525142018.GM4815@noname.redhat.com> References: <1464128732-12667-1-git-send-email-eblake@redhat.com> <1464128732-12667-11-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464128732-12667-11-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH 10/13] raw-posix: Convert to bdrv_co_pwrite_zeroes() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz Am 25.05.2016 um 00:25 hat Eric Blake geschrieben: > Another step on our continuing quest to switch to byte-based > interfaces. > > Signed-off-by: Eric Blake > --- > block/raw-posix.c | 37 +++++++++++++++---------------------- > trace-events | 2 +- > 2 files changed, 16 insertions(+), 23 deletions(-) > > diff --git a/block/raw-posix.c b/block/raw-posix.c > index a4f5a1b..bb691f6 100644 > --- a/block/raw-posix.c > +++ b/block/raw-posix.c > @@ -1252,8 +1252,7 @@ static int aio_worker(void *arg) > } > > static int paio_submit_co(BlockDriverState *bs, int fd, > - int64_t sector_num, QEMUIOVector *qiov, int nb_sectors, > - int type) > + int64_t offset, int count, int type) Removing qiov makes sense if we only want to use the function for write_zeroes and therefore don't need the full power of paio_submit(). I still think that it would be good to convert raw-posix to the (coroutine-based) .bdrv_co_preadv/pwritev and then we will need qiov again. Kevin