From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53095)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1b5spo-000292-Lk
	for qemu-devel@nongnu.org; Thu, 26 May 2016 06:48:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1b5spf-0007C5-8N
	for qemu-devel@nongnu.org; Thu, 26 May 2016 06:48:11 -0400
Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:38466)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1b5spe-0007Bv-VG
	for qemu-devel@nongnu.org; Thu, 26 May 2016 06:48:03 -0400
Received: from pps.filterd (m0048827.ppops.net [127.0.0.1])
	by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id
	u4QAlDRk044003
	for <qemu-devel@nongnu.org>; Thu, 26 May 2016 06:48:02 -0400
Message-Id: <201605261048.u4QAlDRk044003@mx0a-001b2d01.pphosted.com>
Received: from e28smtp08.in.ibm.com (e28smtp08.in.ibm.com [125.16.236.8])
	by mx0a-001b2d01.pphosted.com with ESMTP id 235d4vj229-1
	(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)
	for <qemu-devel@nongnu.org>; Thu, 26 May 2016 06:48:01 -0400
Received: from localhost
	by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <bharata@linux.vnet.ibm.com>;
	Thu, 26 May 2016 16:17:56 +0530
Date: Thu, 26 May 2016 16:17:36 +0530
From: Bharata B Rao <bharata@linux.vnet.ibm.com>
Reply-To: bharata@linux.vnet.ibm.com
References: <1463024905-28401-1-git-send-email-bharata@linux.vnet.ibm.com>
	<1463024905-28401-4-git-send-email-bharata@linux.vnet.ibm.com>
	<09a5f97d-8362-80b4-4623-5d125169b0a1@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <09a5f97d-8362-80b4-4623-5d125169b0a1@redhat.com>
Subject: Re: [Qemu-devel] [for-2.7 PATCH v3 03/15] cpu: Reclaim vCPU objects
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, mjrosato@linux.vnet.ibm.com, thuth@redhat.com, pkrempa@redhat.com, Zhu Guihua <zhugh.fnst@cn.fujitsu.com>, ehabkost@redhat.com, aik@ozlabs.ru, armbru@redhat.com, agraf@suse.de, borntraeger@de.ibm.com, qemu-ppc@nongnu.org, Chen Fan <chen.fan.fnst@cn.fujitsu.com>, Gu Zheng <guz.fnst@cn.fujitsu.com>, imammedo@redhat.com, mdroth@linux.vnet.ibm.com, afaerber@suse.de, david@gibson.dropbear.id.au

On Thu, May 26, 2016 at 12:19:05PM +0200, Paolo Bonzini wrote:
> 
> 
> On 12/05/2016 05:48, Bharata B Rao wrote:
> > @@ -1531,6 +1563,9 @@ static void tcg_exec_all(void)
> >                  break;
> >              }
> >          } else if (cpu->stop || cpu->stopped) {
> > +            if (cpu->unplug) {
> 
> This "if" is unnecessary.  next_cpu is not used anymore after the
> "break", so the store is dead.

next_cpu is a global here. Won't tcg_exec_all() continue with running the
next_cpu when it is called the next time ?

Regards,
Bharata.