From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5wYh-0003bQ-82 for qemu-devel@nongnu.org; Thu, 26 May 2016 10:46:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5wYc-00039m-6W for qemu-devel@nongnu.org; Thu, 26 May 2016 10:46:46 -0400 Date: Thu, 26 May 2016 15:46:29 +0100 From: "Richard W.M. Jones" Message-ID: <20160526144629.GH28935@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] hw/arm/virt: Reject gic-version=host for non-KVM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cole Robinson Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, qemu-arm@nongnu.org On Thu, May 26, 2016 at 10:31:25AM -0400, Cole Robinson wrote: > If you try to gic-version=host with TCG on a KVM aarch64 host, > qemu segfaults, since host requires KVM APIs. > > Explicitly reject gic-version=host if KVM is not enabled > > https://bugzilla.redhat.com/show_bug.cgi?id=1339977 > Signed-off-by: Cole Robinson > --- > hw/arm/virt.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index e77ed88..1e82597 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -1122,10 +1122,14 @@ static void machvirt_init(MachineState *machine) > * KVM is not available yet > */ > if (!gic_version) { > + if (!kvm_enabled()) { > + error_report("gic-version=host requires KVM"); > + exit(1); > + } The problem with this is if I'm using TCG fallback mode, how can I specify the right gic-version? ie: -M virt,gic-version=host,accel=kvm:tcg Only qemu knows if KVM is going to be enabled. The same problem happens with '-cpu host' BTW. I really want a "make it work" option, as I've said on several previous occasions on this list eg: https://lists.nongnu.org/archive/html/qemu-devel/2014-08/msg04173.html Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v