qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: qemu-devel@nongnu.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL 11/11] vfio: Check that IOMMU MR translates to system address space
Date: Thu, 26 May 2016 12:01:38 -0600	[thread overview]
Message-ID: <20160526180137.13473.59414.stgit@gimli.home> (raw)
In-Reply-To: <20160526175810.13473.82479.stgit@gimli.home>

From: Alexey Kardashevskiy <aik@ozlabs.ru>

At the moment IOMMU MR only translate to the system memory.
However if some new code changes this, we will need clear indication why
it is not working so here is the check.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
 hw/vfio/common.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index e2d5a8d..e51ed3a 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -269,6 +269,12 @@ static void vfio_iommu_map_notify(Notifier *n, void *data)
 
     trace_vfio_iommu_map_notify(iova, iova + iotlb->addr_mask);
 
+    if (iotlb->target_as != &address_space_memory) {
+        error_report("Wrong target AS \"%s\", only system memory is allowed",
+                     iotlb->target_as->name ? iotlb->target_as->name : "none");
+        return;
+    }
+
     /*
      * The IOMMU TLB entry we have just covers translation through
      * this IOMMU to its immediate target.  We need to translate

  parent reply	other threads:[~2016-05-26 18:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-26 18:00 [Qemu-devel] [PULL 00/11] VFIO updates 2016-05-26 Alex Williamson
2016-05-26 18:00 ` [Qemu-devel] [PULL 01/11] vfio: Enable sparse mmap capability Alex Williamson
2016-05-26 18:00 ` [Qemu-devel] [PULL 02/11] vfio: Create device specific region info helper Alex Williamson
2016-05-26 18:00 ` [Qemu-devel] [PULL 03/11] vfio/pci: Fix return of vfio_populate_vga() Alex Williamson
2016-05-26 18:00 ` [Qemu-devel] [PULL 04/11] vfio/pci: Consolidate VGA setup Alex Williamson
2016-05-26 18:01 ` [Qemu-devel] [PULL 05/11] vfio/pci: Setup BAR quirks after capabilities probing Alex Williamson
2016-05-26 18:01 ` [Qemu-devel] [PULL 06/11] vfio/pci: Intel graphics legacy mode assignment Alex Williamson
2016-05-26 18:01 ` [Qemu-devel] [PULL 07/11] vfio/pci: Add a separate option for IGD OpRegion support Alex Williamson
2016-05-26 18:01 ` [Qemu-devel] [PULL 08/11] vfio/pci: Add IGD documentation Alex Williamson
2016-05-26 18:01 ` [Qemu-devel] [PULL 09/11] vfio: Fix 128 bit handling when deleting region Alex Williamson
2016-05-26 18:01 ` [Qemu-devel] [PULL 10/11] memory: Fix IOMMU replay base address Alex Williamson
2016-05-26 18:01 ` Alex Williamson [this message]
2016-05-26 19:07 ` [Qemu-devel] [PULL 00/11] VFIO updates 2016-05-26 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160526180137.13473.59414.stgit@gimli.home \
    --to=alex.williamson@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).