From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56826) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b687m-0000iR-Le for qemu-devel@nongnu.org; Thu, 26 May 2016 23:07:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b687h-00043C-9F for qemu-devel@nongnu.org; Thu, 26 May 2016 23:07:45 -0400 Date: Fri, 27 May 2016 13:07:36 +1000 From: David Gibson Message-ID: <20160527030736.GR17226@voom.fritz.box> References: <1463024905-28401-1-git-send-email-bharata@linux.vnet.ibm.com> <1463024905-28401-2-git-send-email-bharata@linux.vnet.ibm.com> <4d2629df-500b-f5b3-e3b0-5b377c16454a@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LQyQLyduEnelPo/g" Content-Disposition: inline In-Reply-To: <4d2629df-500b-f5b3-e3b0-5b377c16454a@redhat.com> Subject: Re: [Qemu-devel] [for-2.7 PATCH v3 01/15] exec: Remove cpu from cpus list during cpu_exec_exit() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Bharata B Rao , qemu-devel@nongnu.org, mjrosato@linux.vnet.ibm.com, thuth@redhat.com, pkrempa@redhat.com, ehabkost@redhat.com, aik@ozlabs.ru, armbru@redhat.com, agraf@suse.de, borntraeger@de.ibm.com, qemu-ppc@nongnu.org, imammedo@redhat.com, mdroth@linux.vnet.ibm.com, afaerber@suse.de --LQyQLyduEnelPo/g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 26, 2016 at 12:12:41PM +0200, Paolo Bonzini wrote: >=20 >=20 > On 12/05/2016 05:48, Bharata B Rao wrote: > > CPUState *cpu gets added to the cpus list during cpu_exec_init(). It > > should be removed from cpu_exec_exit(). > >=20 > > cpu_exec_exit() is called from generic CPU::instance_finalize and some > > archs like PowerPC call it from CPU unrealizefn. So ensure that we > > dequeue the cpu only once. >=20 > I think the better thing would be to call it from CPU::unrealize, but > this patch is okay too. >=20 > Thanks, >=20 > Paolo Thanks for the review Paolo. However, what I'm really unclear on is what is the next step towards merging these. Will you take them through your tree? Should Bharata send a formal pull request with the prelim patches? If so, to whom? > > Now -1 value for cpu->cpu_index indicates that we have already dequeued > > the cpu for CONFIG_USER_ONLY case also. > >=20 > > Signed-off-by: Bharata B Rao > > Reviewed-by: David Gibson > > Reviewed-by: Thomas Huth >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --LQyQLyduEnelPo/g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXR7n4AAoJEGw4ysog2bOSe5kQALliONNNNVvkTzQbppMzQoOb G6SI9H8JCKgj+cSFkYANT3wY/PxktHaMZ3t8GlYfnkl2wbsWcp9DFFiqWbxz5gOW D0PghI6l5Q54Qmsp1VCgO+KjBMSXmaclSULrxzUX85BhTb0MAS0FMA2Xvfb73pj8 /WBpvIihOBArFx5sDfwFNdmmm+wRehhC2Hv7gqL86d/1oSdkyEDOIpkkRIMxPKw6 BUWSyWo0vVBbFdQtBorb1l7A00IFkxcZCCnZq7VW07VQ2nqELrrfcC2EmXsZ72bH MMQHJBTyUbfCekGaWDnVa2iKLFTfzqUlkVcLtxAtMsPu4mxW7iv1NG/z5thcGKFs pZGTyfcdvUqRNjyUq0+0TSh1F8RuqdvJpyCteWY8gWYvHEVWlssnJCJN79w5MJG2 vDhkfKY6BGl/gRWqf7itHW8TB1HjbpN0rh0UajTK2R8kNg7ZqTIZ1JhZti+FrR8X ZZxKi0pDXlsTisu+F/w+2Cr8JWu5j1ibtb9hxG5xkUA0Pp4o8l2mCAnUpuK60bmz 3ACDYg8KL133l45FOPgly2Z6loUwNxooBNEwMp9aDOyVOQbjPUr2tKkcg6gDL8A0 LuEUhAnw96t5pphHNAsrD9H70xkIRlLy0cr0scLf/6I1IyKIOhJ0PVbBxlFo7sbu YxlLcXBFMamayq7SEFqA =HGQo -----END PGP SIGNATURE----- --LQyQLyduEnelPo/g--