From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6CPs-0002Ap-I5 for qemu-devel@nongnu.org; Fri, 27 May 2016 03:42:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6CPq-0002UL-Kh for qemu-devel@nongnu.org; Fri, 27 May 2016 03:42:43 -0400 Date: Fri, 27 May 2016 15:42:35 +0800 From: Fam Zheng Message-ID: <20160527074235.GA15113@ad.usersys.redhat.com> References: <1463470536-8981-1-git-send-email-famz@redhat.com> <1463470536-8981-7-git-send-email-famz@redhat.com> <16b7f2aa-3c9a-ae48-b2c1-b7a55e06510c@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16b7f2aa-3c9a-ae48-b2c1-b7a55e06510c@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 06/27] block: Make bdrv_reopen_{commit, abort} private functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, Kevin Wolf , Jeff Cody , Markus Armbruster , Eric Blake , John Snow , qemu-block@nongnu.org, berrange@redhat.com, pbonzini@redhat.com, den@openvz.org, stefanha@redhat.com On Tue, 05/24 18:09, Max Reitz wrote: > On 17.05.2016 09:35, Fam Zheng wrote: > > As parts of the transactional reopen, they are not necessary outside > > block.c. Make them static. > > > > Signed-off-by: Fam Zheng > > --- > > block.c | 6 ++++-- > > include/block/block.h | 2 -- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/block.c b/block.c > > index 1b42303..ad3663c 100644 > > --- a/block.c > > +++ b/block.c > > @@ -1943,6 +1943,8 @@ BlockReopenQueue *bdrv_reopen_queue(BlockReopenQueue *bs_queue, > > * to all devices. > > * > > */ > > +static void bdrv_reopen_commit(BDRVReopenState *reopen_state); > > +static void bdrv_reopen_abort(BDRVReopenState *reopen_state); > > I'd rather put these declarations above the comment describing > bdrv_reopen_multiple(); or just at the top of the file, we have two such > declarations there already. Right, moving them to above the comment. Fam