From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6Eb0-0007Gu-Os for qemu-devel@nongnu.org; Fri, 27 May 2016 06:02:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6Eaw-00069b-Ir for qemu-devel@nongnu.org; Fri, 27 May 2016 06:02:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46033) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6Eaw-00069A-DY for qemu-devel@nongnu.org; Fri, 27 May 2016 06:02:18 -0400 Date: Fri, 27 May 2016 15:32:14 +0530 From: Amit Shah Message-ID: <20160527100214.GE4456@grmbl.mre> References: <69ef1f36b0f882fc5ba9491fb272fa5f83ac1d3d.1464242913.git.amit.shah@redhat.com> <574710C1.6070705@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <574710C1.6070705@redhat.com> Subject: Re: [Qemu-devel] [PULL 25/28] migration: define 'tls-creds' and 'tls-hostname' migration parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Peter Maydell , qemu list , "Dr. David Alan Gilbert" , Juan Quintela On (Thu) 26 May 2016 [09:05:37], Eric Blake wrote: > > @@ -667,6 +702,21 @@ > > # auto-converge detects that migration is not making > > # progress. The default value is 10. (Since 2.7) > > # > > +# @tls-creds: ID of the 'tls-creds' object that provides credentials for > > +# establishing a TLS connection over the migration data channel. > > +# On the outgoing side of the migration, the credentials must > > +# be for a 'client' endpoint, while for the incoming side the > > +# credentials must be for a 'server' endpoint. Setting this > > +# will enable TLS for all migrations. The default is unset, > > +# resulting in unsecured migration at the QEMU level. (Since 2.6) > > Missed a swap to call out 2.7 Ugh, I did miss a few didn't I? Dan, can you please follow up with the fixes Eric sugests? Thanks, Amit