From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b71Qc-0004Gb-NI for qemu-devel@nongnu.org; Sun, 29 May 2016 10:10:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b71QY-0003sx-Hm for qemu-devel@nongnu.org; Sun, 29 May 2016 10:10:54 -0400 Received: from stormwind.0x539.de ([188.40.127.183]:57570) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b71QY-0003qe-Ao for qemu-devel@nongnu.org; Sun, 29 May 2016 10:10:50 -0400 Date: Sun, 29 May 2016 16:10:35 +0200 From: Philipp Kern Message-ID: <20160529141035.GA30208@desktop.kern.pm> References: <1439897731-3645-1-git-send-email-phil@philkern.de> <1439898655-6275-1-git-send-email-phil@philkern.de> <55D60B51.1000201@tuxfamily.org> <55DD8472.4050600@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="M9NhX3UHpAaciwkO" Content-Disposition: inline In-Reply-To: <55DD8472.4050600@suse.de> Subject: Re: [Qemu-devel] [PATCH] target-s390x: Mask the SIGP order_code to 8bit. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Thomas Huth , qemu-devel@nongnu.org, Richard Henderson --M9NhX3UHpAaciwkO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed, Aug 26, 2015 at 11:18:42AM +0200, Alexander Graf wrote: > On 20.08.15 19:16, Thomas Huth wrote: > > On 18/08/15 04:50, Philipp Kern wrote: > >> According to "CPU Signaling and Response", "Signal-Processor Orders", > >> the order field is bit position 56-63. Without this, the Linux > >> guest kernel is sometimes unable to stop emulation and enters > >> an infinite loop of "XXX unknown sigp: 0xffffffff00000005". > >> > >> Signed-off-by: Philipp Kern > >> --- > >> target-s390x/misc_helper.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/target-s390x/misc_helper.c b/target-s390x/misc_helper.c > >> index 8eac0e1..0f0907c 100644 > >> --- a/target-s390x/misc_helper.c > >> +++ b/target-s390x/misc_helper.c > >> @@ -500,7 +500,7 @@ uint32_t HELPER(sigp)(CPUS390XState *env, uint64_t= order_code, uint32_t r1, > >> /* Remember: Use "R1 or R1 + 1, whichever is the odd-numbered reg= ister" > >> as parameter (input). Status (output) is always R1. */ > >> =20 > >> - switch (order_code) { > >> + switch (order_code & 0xff) { > >> case SIGP_SET_ARCH: > >> /* switch arch */ > >> break; > >=20 > > Reviewed-by: Thomas Huth > Thanks, applied to s390-next. it looks like this patch never made it to qemu master. Could someone apply = it please? (It also seems to be the only pending patch in agraf's s390-next[1].) Kind regards and thanks Philipp Kern [1] https://github.com/agraf/qemu/tree/s390-next --M9NhX3UHpAaciwkO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXSvhZAAoJEERuJUU10FbsGrUH/0QvZZp/BgaMlmJD8ntQUq/Y L3qvsB9tnHQNkyP4juqBfNsCc1kaHhrIrobZhQpd8kYsMFnAR7REQ5/FBF1dY8CV xacVzjYuQTlHpgr/PNGvqFF4PBK3mvtAbJmEMmYhTGxlge4C7NbQ9bRwWE0zLrf7 5/cxuTvGQxAmadpKzyTHsOPxWIFmCaxYMQC5jp8TSb3ecLUBb2KFctJ+zvlu+nXU E+og7fQcftx69Ng6VXRy9jiL2AN2RLGdHfg0R3acWW90L3ZaKl/ZWXIgRu55ryaI mOHVgHqcMgB6zamYRmqj/agTY2sp0Du/UKRjYmJxL6L+4BW2kAb58vh2ZEgf+ZY= =R50L -----END PGP SIGNATURE----- --M9NhX3UHpAaciwkO--