From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7Row-0002Cu-Qt for qemu-devel@nongnu.org; Mon, 30 May 2016 14:21:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7Rot-0004BV-K3 for qemu-devel@nongnu.org; Mon, 30 May 2016 14:21:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56342) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7Rot-0004BR-EM for qemu-devel@nongnu.org; Mon, 30 May 2016 14:21:43 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 16CAB85366 for ; Mon, 30 May 2016 18:21:43 +0000 (UTC) Date: Mon, 30 May 2016 21:21:39 +0300 From: "Michael S. Tsirkin" Message-ID: <20160530182139.GA10052@redhat.com> References: <1463496205-251412-1-git-send-email-imammedo@redhat.com> <1463496205-251412-31-git-send-email-imammedo@redhat.com> <573B38CB.2020609@redhat.com> <20160518100927.0a9306b4@nial.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160518100927.0a9306b4@nial.brq.redhat.com> Subject: Re: [Qemu-devel] [PATCH 30/33] acpi: cpuhp: add cpu._OST handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: Eric Blake , drjones@redhat.com, ehabkost@redhat.com, rkrcmar@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, marcel@redhat.com On Wed, May 18, 2016 at 10:09:27AM +0200, Igor Mammedov wrote: > On Tue, 17 May 2016 09:29:15 -0600 > Eric Blake wrote: > > > On 05/17/2016 08:43 AM, Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > > --- > > > hw/acpi/cpu.c | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++ > > > hw/acpi/ich9.c | 3 ++ > > > hw/acpi/piix4.c | 3 ++ > > > include/hw/acpi/cpu.h | 4 +++ > > > qapi-schema.json | 3 +- > > > trace-events | 2 ++ > > > 6 files changed, 97 insertions(+), 1 deletion(-) > > > > > > > > +++ b/qapi-schema.json > > > @@ -4018,8 +4018,9 @@ > > > ## @ACPISlotType > > > # > > > # @DIMM: memory slot > > > +# @CPU: logical CPU slot > > > > Missing a marker '(since 2.7)' > thanks, fixed in v2. v2 was never posted. > > > # > > > -{ 'enum': 'ACPISlotType', 'data': [ 'DIMM' ] } > > > +{ 'enum': 'ACPISlotType', 'data': [ 'DIMM', 'CPU' ] } > > > > Hmm. ACPISlotType is already on our whitelist of exceptions that allow > > upper-case names (we prefer lower), so adding another one doesn't > > necessarily hurt. > I'll keep that in mind. >