From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36728)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1b7P56-0006Xi-W6
	for qemu-devel@nongnu.org; Mon, 30 May 2016 11:26:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1b7P52-0006wJ-VV
	for qemu-devel@nongnu.org; Mon, 30 May 2016 11:26:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59873)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1b7P52-0006wE-Pk
	for qemu-devel@nongnu.org; Mon, 30 May 2016 11:26:12 -0400
Date: Mon, 30 May 2016 18:26:09 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20160530182501-mutt-send-email-mst@redhat.com>
References: <1464599682-14592-1-git-send-email-leonid.bloch@ravellosystems.com>
	<1464599682-14592-2-git-send-email-leonid.bloch@ravellosystems.com>
	<20160530144712.GA1702@redhat.com>
	<D324DD4C-6E11-45A0-931C-AF6FD4BFF6A9@daynix.com>
	<20160530181036-mutt-send-email-mst@redhat.com>
	<4CAECCE6-DF0E-41EA-AF9C-25867B57E00D@daynix.com>
	<20160530181846-mutt-send-email-mst@redhat.com>
	<A0CAFCD2-752B-4607-85CC-ED9961719392@daynix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <A0CAFCD2-752B-4607-85CC-ED9961719392@daynix.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v6 01/17] pci: fix unaligned access in
 pci_xxx_quad()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dmitry Fleytman <dmitry@daynix.com>
Cc: Leonid Bloch <leonid.bloch@ravellosystems.com>, QEMU Developers <qemu-devel@nongnu.org>, Jason Wang <jasowang@redhat.com>, Leonid Bloch <leonid@daynix.com>, Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>

On Mon, May 30, 2016 at 06:22:35PM +0300, Dmitry Fleytman wrote:
>=20
> > On 30 May 2016, at 18:19 PM, Michael S. Tsirkin <mst@redhat.com> wrot=
e:
> >=20
> > On Mon, May 30, 2016 at 06:14:56PM +0300, Dmitry Fleytman wrote:
> >>    Does DSN generation function pass unaligned offsets?
> >>    It does not look like it does=E2=80=A6
> >>=20
> >>=20
> >> It does according to clang sanitiser.
> >=20
> >=20
> > Oh so it's a clang false positive?
>=20
> I think not.
> The capability itself is 8-bytes aligned but 64-bit serial number insid=
e of it is not because of 32 bit header in front of it.

Oh right. Things like this should really go into commit log
in the future.
For now a code comment in pci set/get that explains that
alignment in capabilities is generally at dword not qword
boundary would be enough.

> >=20
> > --=20
> > MST