From: Stefan Hajnoczi <stefanha@redhat.com>
To: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Cc: pbonzini@redhat.com, imammedo@redhat.com, gleb@kernel.org,
mtosatti@redhat.com, mst@redhat.com, rth@twiddle.net,
ehabkost@redhat.com, dan.j.williams@intel.com,
kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 01/15] pc-dimm: get memory region from ->get_memory_region()
Date: Mon, 30 May 2016 11:36:19 -0700 [thread overview]
Message-ID: <20160530183619.GE1366@stefanha-x1.localdomain> (raw)
In-Reply-To: <1463732412-99212-2-git-send-email-guangrong.xiao@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
On Fri, May 20, 2016 at 04:19:58PM +0800, Xiao Guangrong wrote:
> Curretly, the memory region of backed memory is all directly
s/Curretly/Currently/
> mapped to guest's address space, however, it will be not true
> for nvdimm device if we introduce nvdimm label which only can
> be indirectly accessed by ACPI DSM method
>
> Also it improves the comments a bit to reflect this fact
>
> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
> ---
> hw/mem/pc-dimm.c | 3 ++-
> include/hw/mem/pc-dimm.h | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-05-30 18:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 8:19 [Qemu-devel] [PATCH v2 00/15] PATCH 00/15] NVDIMM: introduce nvdimm label support Xiao Guangrong
2016-05-20 8:19 ` [Qemu-devel] [PATCH v2 01/15] pc-dimm: get memory region from ->get_memory_region() Xiao Guangrong
2016-05-30 18:36 ` Stefan Hajnoczi [this message]
2016-05-20 8:19 ` [Qemu-devel] [PATCH v2 02/15] pc-dimm: introduce realize callback Xiao Guangrong
2016-05-30 18:37 ` Stefan Hajnoczi
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 03/15] pc-dimm: keep the state of the whole backend memory Xiao Guangrong
2016-05-30 18:42 ` Stefan Hajnoczi
2016-05-31 2:04 ` Xiao Guangrong
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 04/15] nvdimm: support nvdimm label Xiao Guangrong
2016-05-30 18:46 ` Stefan Hajnoczi
2016-06-28 7:48 ` Paolo Bonzini
2016-06-28 9:04 ` Stefan Hajnoczi
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 05/15] acpi: add aml_object_type Xiao Guangrong
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 06/15] acpi: add aml_call5 Xiao Guangrong
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 07/15] nvdimm acpi: set HDLE properly Xiao Guangrong
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 08/15] nvdimm acpi: save arg3 of _DSM method Xiao Guangrong
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 09/15] nvdimm acpi: check UUID Xiao Guangrong
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 10/15] nvdimm acpi: abstract the operations for root & nvdimm devices Xiao Guangrong
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 11/15] nvdimm acpi: check revision Xiao Guangrong
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 12/15] nvdimm acpi: support Get Namespace Label Size function Xiao Guangrong
2016-05-30 18:49 ` Stefan Hajnoczi
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 13/15] nvdimm acpi: support Get Namespace Label Data function Xiao Guangrong
2016-05-30 18:51 ` Stefan Hajnoczi
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 14/15] nvdimm acpi: support Set " Xiao Guangrong
2016-05-30 18:51 ` Stefan Hajnoczi
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 15/15] docs: add NVDIMM ACPI documentation Xiao Guangrong
2016-05-30 18:52 ` [Qemu-devel] [PATCH v2 00/15] PATCH 00/15] NVDIMM: introduce nvdimm label support Stefan Hajnoczi
2016-05-31 2:09 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160530183619.GE1366@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=ehabkost@redhat.com \
--cc=gleb@kernel.org \
--cc=guangrong.xiao@linux.intel.com \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).