From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7SIL-0002yo-Bk for qemu-devel@nongnu.org; Mon, 30 May 2016 14:52:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7SIH-0008MH-6s for qemu-devel@nongnu.org; Mon, 30 May 2016 14:52:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7SIG-0008MD-Ug for qemu-devel@nongnu.org; Mon, 30 May 2016 14:52:05 -0400 Date: Mon, 30 May 2016 11:52:01 -0700 From: Stefan Hajnoczi Message-ID: <20160530185201.GL1366@stefanha-x1.localdomain> References: <1463732412-99212-1-git-send-email-guangrong.xiao@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1X+6QtwRodzgDPAC" Content-Disposition: inline In-Reply-To: <1463732412-99212-1-git-send-email-guangrong.xiao@linux.intel.com> Subject: Re: [Qemu-devel] [PATCH v2 00/15] PATCH 00/15] NVDIMM: introduce nvdimm label support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: pbonzini@redhat.com, imammedo@redhat.com, gleb@kernel.org, mtosatti@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org --1X+6QtwRodzgDPAC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 20, 2016 at 04:19:57PM +0800, Xiao Guangrong wrote: > Changelog in v2: > Thanks for Stefan's review, the changes in this version are: > - rename nvdimm device parameter 'reserve-label' to 'label-size' to > specify the size of label > - add comment to explain why assert() used in nvdimm_assert_rw_label_data= () > is safe > - follow the code style of 'foo() return;' if nothing is returned by fool= () > - fix the value of "Non-existing-Memory-Device" > - fix the handling the DSM functions we currently did not support >=20 > =20 > This patchset is against commit 2912f22759 (fixup! virtio: convert to use= DMA > api) on pci branch of Michael's git tree and can be found at: > https://github.com/xiaogr/qemu.git nvdimm-label-v2 >=20 > This is the last part of vNVDIMM implementation which introduces nvdimm > label support >=20 > Currently Linux NVDIMM driver does not support namespace operation on this > kind of PMEM, apply below changes to support dynamical namespace: >=20 > @@ -798,7 +823,8 @@ static int acpi_nfit_register_dimms(struct acpi_nfit_= desc *a > continue; > } > =20 > - if (nfit_mem->bdw && nfit_mem->memdev_pmem) > + //if (nfit_mem->bdw && nfit_mem->memdev_pmem) > + if (nfit_mem->memdev_pmem) > flags |=3D NDD_ALIASING; >=20 > You can append a NVDIMM device in guest and do: =20 > # cd /sys/bus/nd/devices/ > # cd namespace0.0/ > # echo `uuidgen` > uuid > # echo `expr 1024 \* 1024 \* 128` > size > then reload nd.pmem.ko >=20 > You can see /dev/pmem0 appears >=20 > Xiao Guangrong (15): > pc-dimm: get memory region from ->get_memory_region() > pc-dimm: introduce realize callback > pc-dimm: keep the state of the whole backend memory > nvdimm: support nvdimm label > acpi: add aml_object_type > acpi: add aml_call5 > nvdimm acpi: set HDLE properly > nvdimm acpi: save arg3 of _DSM method > nvdimm acpi: check UUID > nvdimm acpi: abstract the operations for root & nvdimm devices > nvdimm acpi: check revision > nvdimm acpi: support Get Namespace Label Size function > nvdimm acpi: support Get Namespace Label Data function > nvdimm acpi: support Set Namespace Label Data function > docs: add NVDIMM ACPI documentation >=20 > docs/specs/acpi_nvdimm.txt | 132 +++++++++++++++ > hw/acpi/aml-build.c | 22 +++ > hw/acpi/nvdimm.c | 400 ++++++++++++++++++++++++++++++++++++++= ++---- > hw/mem/nvdimm.c | 122 ++++++++++++++ > hw/mem/pc-dimm.c | 21 ++- > include/hw/acpi/aml-build.h | 3 + > include/hw/mem/nvdimm.h | 55 +++++- > include/hw/mem/pc-dimm.h | 6 +- > 8 files changed, 723 insertions(+), 38 deletions(-) > create mode 100644 docs/specs/acpi_nvdimm.txt I have reviewed the non-ACPI parts of this series. Aside from minor comments: Reviewed-by: Stefan Hajnoczi --1X+6QtwRodzgDPAC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXTIvRAAoJEJykq7OBq3PI4Z8IAJS801toX1z7KoHvYwijiT5T AJQ9Q9YdIfbw5qSze2P3IYBeiNVasXuFVSKC0gPGlm1hRL3Wj8VPRDLGcV7nbW5f 2Ekx8oXsghlhFV4Aff1wuVR+WLG/JSeeEgI2lsL7Q8eFCSPqvIfRLfMnor0BljqF ZFWrWrKt32PolhFR1qU+NGA9utJVGt4lXTT7vYPxydPp6J7MKkecA+M2qOmwPz3g twpzUU51pNFD/qefDZL+tA2B2XAD2tO65Mw/QXirE8TgLa4Ply+ghbIUrvqWJt/Z /TTOZ+dM61CrHZHbTK2VRE43Cz9dibs8+jUnpZw6p+S7C+9/CW1CbEGFoD7paC0= =uLCb -----END PGP SIGNATURE----- --1X+6QtwRodzgDPAC--