From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50717) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7Uaj-0003ol-8c for qemu-devel@nongnu.org; Mon, 30 May 2016 17:19:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7Uah-0000Eo-TV for qemu-devel@nongnu.org; Mon, 30 May 2016 17:19:17 -0400 Date: Mon, 30 May 2016 23:19:11 +0200 From: Aurelien Jarno Message-ID: <20160530211911.GA27823@aurel32.net> References: <1464338922-13102-1-git-send-email-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464338922-13102-1-git-send-email-mark.cave-ayland@ilande.co.uk> Subject: Re: [Qemu-devel] [PATCH 0/2] macio: switch over to new byte-aligned DMA helpers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, pbonzini@redhat.com On 2016-05-27 09:48, Mark Cave-Ayland wrote: > Here is a tidied up version of my patch to convert the macio controller over to > using the new byte-aligned DMA helpers. > > The first patch is just a hack and temporarily disables unaligned iovec > truncation in the DMA helper (as discussed in the recent thread) until Paolo or > someone else can devise a proper solution. Without this, the subsequent switch > over to the DMA helpers will appear to work during a Darwin PPC install but the > resulting image is corrupt and will fail to boot. > > The second patch is the real one and switches the macio controller over to use > the new byte-aligned DMA helpers. Here I see a speed-up of around 2.5x-3x for > a typical Darwin PPC installation compared to the previous code. > > Aurelien, I'd be grateful if you could test the TRIM path as I know this is > something you've had issues with before and I couldn't quite figure out how to > reproduce your TRIM tests from before. I have just tested the TRIM path, all works fine with your 2 patches applied. Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net