From: David Gibson <david@gibson.dropbear.id.au>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com,
crosthwaite.peter@gmail.com, rth@twiddle.net,
bharata@linux.vnet.ibm.com, thuth@redhat.com
Subject: Re: [Qemu-devel] [PATCH] fixup! exec: Do vmstate unregistration from cpu_exec_exit()
Date: Tue, 31 May 2016 10:02:08 +1000 [thread overview]
Message-ID: <20160531000208.GE17226@voom.fritz.box> (raw)
In-Reply-To: <1464621749-232847-1-git-send-email-imammedo@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]
On Mon, May 30, 2016 at 05:22:29PM +0200, Igor Mammedov wrote:
> with all header changes merged in current master (d6550e9ed2)
> above patch breaks compilation with:
> exec.c: In function ‘cpu_exec_exit’:
> exec.c:661:9: error: implicit declaration of function ‘vmstate_unregister’ [-Werror=implicit-function-declaration]
> vmstate_unregister(NULL, cc->vmsd, cpu);
>
> pls squash this fixup in orginal patch
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Already made the same change when I pulled it into my tree.
> ---
> exec.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/exec.c b/exec.c
> index c5dd58e..a0327a9 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -62,6 +62,8 @@
> #include "qemu/mmap-alloc.h"
> #endif
>
> +#include "migration/vmstate.h"
> +
> //#define DEBUG_SUBPAGE
>
> #if !defined(CONFIG_USER_ONLY)
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-31 0:09 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 3:48 [Qemu-devel] [for-2.7 PATCH v3 00/15] Core based CPU hotplug for PowerPC sPAPR Bharata B Rao
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 01/15] exec: Remove cpu from cpus list during cpu_exec_exit() Bharata B Rao
2016-05-26 10:12 ` Paolo Bonzini
2016-05-27 3:07 ` David Gibson
2016-05-27 9:51 ` Paolo Bonzini
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 02/15] exec: Do vmstate unregistration from cpu_exec_exit() Bharata B Rao
2016-05-26 10:22 ` Paolo Bonzini
2016-05-30 15:22 ` [Qemu-devel] [PATCH] fixup! " Igor Mammedov
2016-05-31 0:02 ` David Gibson [this message]
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 03/15] cpu: Reclaim vCPU objects Bharata B Rao
2016-05-26 10:19 ` Paolo Bonzini
2016-05-26 10:47 ` Bharata B Rao
[not found] ` <201605261048.u4QAibq4039252@mx0a-001b2d01.pphosted.com>
2016-05-26 10:51 ` Paolo Bonzini
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 04/15] cpu: Add a sync version of cpu_remove() Bharata B Rao
2016-05-26 10:22 ` Paolo Bonzini
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 05/15] qdev: hotplug: Introduce HotplugHandler.pre_plug() callback Bharata B Rao
2016-06-02 1:15 ` David Gibson
2016-06-02 9:32 ` Igor Mammedov
2016-06-03 5:10 ` David Gibson
2016-06-03 9:23 ` Igor Mammedov
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 06/15] cpu: Abstract CPU core type Bharata B Rao
2016-06-02 3:38 ` David Gibson
2016-06-02 9:35 ` Igor Mammedov
2016-06-02 18:12 ` Eduardo Habkost
2016-06-03 5:06 ` David Gibson
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 07/15] spapr: Abstract CPU core device and type specific core devices Bharata B Rao
2016-06-03 5:25 ` David Gibson
2016-06-08 9:42 ` Bharata B Rao
2016-06-09 0:45 ` David Gibson
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 08/15] spapr: convert boot CPUs into CPU " Bharata B Rao
2016-06-03 5:32 ` David Gibson
2016-06-08 12:23 ` Bharata B Rao
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 09/15] spapr: CPU hotplug support Bharata B Rao
2016-06-03 6:10 ` David Gibson
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 10/15] xics, xics_kvm: Handle CPU unplug correctly Bharata B Rao
2016-06-03 6:14 ` David Gibson
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 11/15] spapr_drc: Prevent detach racing against attach for CPU DR Bharata B Rao
2016-06-03 6:17 ` David Gibson
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 12/15] spapr: CPU hot unplug support Bharata B Rao
2016-06-03 6:27 ` David Gibson
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 13/15] QMP: Add query-hotpluggable-cpus Bharata B Rao
2016-06-06 5:28 ` David Gibson
2016-06-06 8:42 ` Igor Mammedov
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 14/15] hmp: Add 'info hotpluggable-cpus' HMP command Bharata B Rao
2016-06-06 5:29 ` David Gibson
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 15/15] spapr: implement query-hotpluggable-cpus callback Bharata B Rao
2016-06-06 5:37 ` David Gibson
2016-05-25 6:54 ` [Qemu-devel] [for-2.7 PATCH v3 00/15] Core based CPU hotplug for PowerPC sPAPR Thomas Huth
2016-05-25 16:03 ` Andreas Färber
2016-05-26 6:20 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531000208.GE17226@voom.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=bharata@linux.vnet.ibm.com \
--cc=crosthwaite.peter@gmail.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).