From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7XFH-00054s-Lz for qemu-devel@nongnu.org; Mon, 30 May 2016 20:09:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7XFC-00065c-Au for qemu-devel@nongnu.org; Mon, 30 May 2016 20:09:18 -0400 Received: from ozlabs.org ([103.22.144.67]:46860) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7XFB-00062l-D7 for qemu-devel@nongnu.org; Mon, 30 May 2016 20:09:14 -0400 Date: Tue, 31 May 2016 10:02:08 +1000 From: David Gibson Message-ID: <20160531000208.GE17226@voom.fritz.box> References: <1463024905-28401-3-git-send-email-bharata@linux.vnet.ibm.com> <1464621749-232847-1-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2Ui/8jAYUVG6J+Fv" Content-Disposition: inline In-Reply-To: <1464621749-232847-1-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH] fixup! exec: Do vmstate unregistration from cpu_exec_exit() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, crosthwaite.peter@gmail.com, rth@twiddle.net, bharata@linux.vnet.ibm.com, thuth@redhat.com --2Ui/8jAYUVG6J+Fv Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 30, 2016 at 05:22:29PM +0200, Igor Mammedov wrote: > with all header changes merged in current master (d6550e9ed2) > above patch breaks compilation with: > exec.c: In function =E2=80=98cpu_exec_exit=E2=80=99: > exec.c:661:9: error: implicit declaration of function =E2=80=98vmstate_= unregister=E2=80=99 [-Werror=3Dimplicit-function-declaration] > vmstate_unregister(NULL, cc->vmsd, cpu); >=20 > pls squash this fixup in orginal patch >=20 > Signed-off-by: Igor Mammedov Already made the same change when I pulled it into my tree. > --- > exec.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/exec.c b/exec.c > index c5dd58e..a0327a9 100644 > --- a/exec.c > +++ b/exec.c > @@ -62,6 +62,8 @@ > #include "qemu/mmap-alloc.h" > #endif > =20 > +#include "migration/vmstate.h" > + > //#define DEBUG_SUBPAGE > =20 > #if !defined(CONFIG_USER_ONLY) --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --2Ui/8jAYUVG6J+Fv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXTNSAAAoJEGw4ysog2bOSLk8P/iWhX4MQaUPx5AzxSYtWZMz1 cBdSXc6T8avuo1UEFxhTqTlDZdq7r9RYeLAlpQsHRIA56q5lnSWUYzcztt7rLIzJ +ZLxvFkFNozz4StR55qK0SfqO23C7V37HOX/r4i3Ms8/5ihqGVSmBowHDzXTakfm pFPXYC93DZWmsm7VnBjdzxP6AB5fmDeezX6VOCi4X/Fb7jw4ZxHOiYoayGNSdoKc Qf6RJt01usO9jHFdYsfbfBzWZluaeGsaR2CN40Rc0lXMM7WXlEGuoOLKo8wtgf6E FX6zaMdM84yf4H4FeUi5m/0CcrT1Ul1Vgb8jaYhX+WXkyxUA4TpGvZ3pdUR54Lye rDuJEcVyr3DcwNkWWlpD7hGVELqJT9QBWZSoNuL1mik5JSNfoqOJUf09FxRTYtph UsDBvtnSwy0F+1z/sfdBQ2eObIErj0GEE6BMR2lqB3ozWasiFRYAVI0ySkdVQF4X am75Wcn1NrHIBq7BfLBDs7wob/NFvePR9NSIjdKoKJW8UNHLqNrmb0nS+uHqyoBA ep1W/oCYp+Q//TTa5As/mgFtEYt9ORdrBYPzfrQsPLk7wJn2YSCiaG2ONl4oY2wT SQJ3qkX3e3MDv5AYQotuBayCgSsqP4C/KTKdbgX64wuCGhsJ5dnBPlLJLK9Tz9Fm 2AaqNRWJvTIA4dLXWp5v =ydi8 -----END PGP SIGNATURE----- --2Ui/8jAYUVG6J+Fv--