From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
Fam Zheng <famz@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>,
qemu-block@nongnu.org, qemu-stable@nongnu.org
Subject: [Qemu-devel] [PATCH] block: Fix leak of BdrvIoctlCompletionData when driver returns NULL
Date: Tue, 31 May 2016 16:34:55 +0800 [thread overview]
Message-ID: <20160531083455.31087-1-famz@redhat.com> (raw)
"data" allocated in bdrv_co_do_ioctl is not freed. Free it before
returning.
Cc: qemu-stable@nongnu.org
Reported-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
block/io.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/io.c b/block/io.c
index 2d832aa..aa5a5d7 100644
--- a/block/io.c
+++ b/block/io.c
@@ -2320,6 +2320,7 @@ static void bdrv_ioctl_bh_cb(void *opaque)
bdrv_co_io_em_complete(data->co, -ENOTSUP);
qemu_bh_delete(data->bh);
+ g_free(data);
}
static int bdrv_co_do_ioctl(BlockDriverState *bs, int req, void *buf)
--
2.8.3
next reply other threads:[~2016-05-31 8:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 8:34 Fam Zheng [this message]
2016-05-31 9:14 ` [Qemu-devel] [PATCH] block: Fix leak of BdrvIoctlCompletionData when driver returns NULL Paolo Bonzini
2016-05-31 10:49 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531083455.31087-1-famz@redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).