From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39152) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7frM-0002JF-Gc for qemu-devel@nongnu.org; Tue, 31 May 2016 05:21:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7frI-0006Oo-Tn for qemu-devel@nongnu.org; Tue, 31 May 2016 05:21:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7frI-0006Oj-OF for qemu-devel@nongnu.org; Tue, 31 May 2016 05:21:08 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 690B663301 for ; Tue, 31 May 2016 09:21:08 +0000 (UTC) Date: Tue, 31 May 2016 10:21:04 +0100 From: "Daniel P. Berrange" Message-ID: <20160531092104.GH21628@redhat.com> Reply-To: "Daniel P. Berrange" References: <1461751518-12128-1-git-send-email-berrange@redhat.com> <20160526061742.GD4456@grmbl.mre> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160526061742.GD4456@grmbl.mre> Subject: Re: [Qemu-devel] [PATCH v6 for-2.7 00/28] Convert migration to QIOChannel & support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Juan Quintela On Thu, May 26, 2016 at 11:47:42AM +0530, Amit Shah wrote: > On (Wed) 27 Apr 2016 [11:04:50], Daniel P. Berrange wrote: > > This is an update of patches that were previously posted > > > > FYI: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00829.html > > v1: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg01914.html > > v2: https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg03509.html > > v3: https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg06279.html > > v4: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg02769.html > > v5: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg04591.html > > > > There are no functional changes since v5 posting. This is just a > > rebase to resolve conflicts against master. From my POV this is > > ready for 2.7. > > Thanks, I've applied this series, and sent a pull req. > > I've rebased it to master, which caused a few patches to change (but > not significantly. Majority changes were the dropping of x- in > autoconverge, and the change from qjson.c to migration/qjson.c in > Makefiles. > > I've also updated the 'Since 2.6' to 'Since 2.7' in the qapi > descriptions. > > Each patch compiles fine, and the diffstat is the same (except for one > patch in migration.c, which did not need wrapping after the x- drop). > > The only outstanding request I see is from Juan and me to consider > renaming of the functions that start migrations; that can be addressed > in a follow-up series. > > Dan, can you also fill up a feature page (or two) for this series > based on the template here: > > http://qemu-project.org/NewFeatureTemplate > > that'll help with testing efforts. I've seen the extensive > documentation on your blog, links to them will be great. Thanks for accepting the series. I'll take care of these followup items shortly. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|