From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39502)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1b7ft2-0003ka-Ea
	for qemu-devel@nongnu.org; Tue, 31 May 2016 05:23:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1b7fsx-0006hf-MR
	for qemu-devel@nongnu.org; Tue, 31 May 2016 05:22:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39685)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1b7fsx-0006hb-Gg
	for qemu-devel@nongnu.org; Tue, 31 May 2016 05:22:51 -0400
Date: Tue, 31 May 2016 10:22:46 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160531092246.GI21628@redhat.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
References: <cover.1464242913.git.amit.shah@redhat.com>
	<69ef1f36b0f882fc5ba9491fb272fa5f83ac1d3d.1464242913.git.amit.shah@redhat.com>
	<574710C1.6070705@redhat.com> <20160527100214.GE4456@grmbl.mre>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20160527100214.GE4456@grmbl.mre>
Subject: Re: [Qemu-devel] [PULL 25/28] migration: define 'tls-creds' and
 'tls-hostname' migration parameters
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Eric Blake <eblake@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Juan Quintela <quintela@redhat.com>, qemu list <qemu-devel@nongnu.org>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>

On Fri, May 27, 2016 at 03:32:14PM +0530, Amit Shah wrote:
> On (Thu) 26 May 2016 [09:05:37], Eric Blake wrote:
> 
> > > @@ -667,6 +702,21 @@
> > >  #                          auto-converge detects that migration is not making
> > >  #                          progress. The default value is 10. (Since 2.7)
> > >  #
> > > +# @tls-creds: ID of the 'tls-creds' object that provides credentials for
> > > +#             establishing a TLS connection over the migration data channel.
> > > +#             On the outgoing side of the migration, the credentials must
> > > +#             be for a 'client' endpoint, while for the incoming side the
> > > +#             credentials must be for a 'server' endpoint. Setting this
> > > +#             will enable TLS for all migrations. The default is unset,
> > > +#             resulting in unsecured migration at the QEMU level. (Since 2.6)
> > 
> > Missed a swap to call out 2.7
> 
> Ugh, I did miss a few didn't I?
> 
> Dan, can you please follow up with the fixes Eric sugests?

Yes, will do.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|