From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39656)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1b7ftm-0004Y7-M4
	for qemu-devel@nongnu.org; Tue, 31 May 2016 05:23:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1b7fti-0006qd-23
	for qemu-devel@nongnu.org; Tue, 31 May 2016 05:23:41 -0400
Date: Tue, 31 May 2016 10:23:33 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160531092333.GJ21628@redhat.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
References: <1464324793-29101-1-git-send-email-steven@steven676.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1464324793-29101-1-git-send-email-steven@steven676.net>
Subject: Re: [Qemu-devel] [PATCH] Fix configure test for PBKDF2 in nettle
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Steven Luo <steven@steven676.net>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, qemu-stable@nongnu.org

On Thu, May 26, 2016 at 09:53:13PM -0700, Steven Luo wrote:
> From: Steven Luo <steven+qemu@steven676.net>
> 
> On my Debian jessie system, including nettle/pbkdf2.h does not cause
> NULL to be defined, which causes the test to fail to compile.  Include
> stddef.h to bring in a definition of NULL.
> 
> Cc: qemu-trivial@nongnu.org
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Steven Luo <steven+qemu@steven676.net>
> ---
> I suppose this could also be fixed by defining NULL ourselves, or by
> replacing NULLs with 0s -- if one of those other approaches is
> preferred, let me know.

What you've done here looks just fine to me.

> 
>  configure | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configure b/configure
> index c37fc5f..0aae017 100755
> --- a/configure
> +++ b/configure
> @@ -2342,6 +2342,7 @@ if test "$nettle" != "no"; then
>          nettle="yes"
>  
>          cat > $TMPC << EOF
> +#include <stddef.h>
>  #include <nettle/pbkdf2.h>
>  int main(void) {
>       pbkdf2_hmac_sha256(8, NULL, 1000, 8, NULL, 8, NULL);
> -- 
> 2.1.4
> 

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|