From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40141)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1b7hQ3-0005Yn-Md
	for qemu-devel@nongnu.org; Tue, 31 May 2016 07:01:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1b7hPx-0001Ux-Ot
	for qemu-devel@nongnu.org; Tue, 31 May 2016 07:01:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37169)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1b7hPx-0001Ut-JI
	for qemu-devel@nongnu.org; Tue, 31 May 2016 07:01:01 -0400
Date: Tue, 31 May 2016 19:00:58 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160531110058.GA24019@ad.usersys.redhat.com>
References: <20160527135437.20474-1-famz@redhat.com>
	<20160527135437.20474-5-famz@redhat.com>
	<d3704ac7-0b1a-8492-84f5-ccde37efc273@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d3704ac7-0b1a-8492-84f5-ccde37efc273@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 04/15] Makefile: Rules for docker testing
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>

On Tue, 05/31 10:51, Paolo Bonzini wrote:
> > diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> > new file mode 100644
> > index 0000000..372733d
> > --- /dev/null
> > +++ b/tests/docker/Makefile.include
> > @@ -0,0 +1,121 @@
> > +# Makefile for Docker tests
> > +
> > +include $(SRC_PATH)/rules.mak
> 
> Why include this _and_ include tests/docker/Makefile.include from the
> top Makefile?

This is for quiet-command, which is only conditionally included by top
Makefile.

> 
> I think you should do one of this:
> 
> a) drop this inclusion; nice, but it pollutes the toplevel makefile a bit
> 
> b) do the following:
> 
> - link this file into the build tree in configure
> 
> - include ../../config-host.mak

I prefer we support running from the src tree without running configure, but
$(MAKE) invocations doesn't propagate make variables such as SRC_PATH...

> 
> - add to the toplevel Makefile a rule like
> 
> 	docker docker-%:
> 		$(MAKE) -C tests/docker $@

... and explicitly passing it (and $(V), etc.) here seems very ad-hocery.

> 
> I prefer the latter.  Either would make patch 3 unnecessary.

Maybe I should make patch 3 a patch to make top Makefile include rules.mak
unconditionally?

Fam