From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7jaK-0005hA-RW for qemu-devel@nongnu.org; Tue, 31 May 2016 09:19:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7jaF-0006NR-05 for qemu-devel@nongnu.org; Tue, 31 May 2016 09:19:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7jaE-0006NI-Qc for qemu-devel@nongnu.org; Tue, 31 May 2016 09:19:46 -0400 Date: Tue, 31 May 2016 14:19:42 +0100 From: "Daniel P. Berrange" Message-ID: <20160531131942.GS21628@redhat.com> Reply-To: "Daniel P. Berrange" References: <967bcc3b-e1d5-38db-eb7d-2d07e92c2e19@redhat.com> <20160531113248.GP21628@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160531113248.GP21628@redhat.com> Subject: Re: [Qemu-devel] including the "git describe" output in the QEMU binaries? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: Peter Maydell , qemu devel list , Paolo Bonzini On Tue, May 31, 2016 at 12:32:48PM +0100, Daniel P. Berrange wrote: > On Tue, May 31, 2016 at 01:16:14PM +0200, Laszlo Ersek wrote: > > Hi, > > > > has this been raised / considered before? To me at least it would be > > extremely useful if QEMU binaries built from a git working directory > > returned the output of "git describe" (+ possibly a hint about an > > unclean working directory), when invoked with "-version". > > > > Not volunteering for the implementation, and also not suggesting / > > requesting that others implement it (everyone is busy with real stuff, > > I'm sure); just asking if it's been considered. > > Currently configure supports a --pkgversion flag which is used by people > packaging QEMU in RPM/Debs to include their arbitrary custom version string. > This information is then reported by -version and the appropriate QMP > command. > > We could quite easily make configure default the pkgversion to the current > GIT hash if --pkgversion is not explicitly given. Oh and the nice thing about this is that it is plumbed into libvirt, so whenever libvirt starts a guest, it will log the pkgversion associated with QEMU to /var/log/libvirt/qemu/$GUEST.log Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|