From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41887)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1b7jdk-0007za-Qo
	for qemu-devel@nongnu.org; Tue, 31 May 2016 09:23:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1b7jdg-00072i-1a
	for qemu-devel@nongnu.org; Tue, 31 May 2016 09:23:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60411)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1b7jdf-000725-Ry
	for qemu-devel@nongnu.org; Tue, 31 May 2016 09:23:19 -0400
Date: Tue, 31 May 2016 14:23:15 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160531132315.GT21628@redhat.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
References: <1464689222-1513-1-git-send-email-den@openvz.org>
	<574D887C.7010806@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <574D887C.7010806@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] trace: enable trace events in qemu-img
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: "Denis V. Lunev" <den@openvz.org>, qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

On Tue, May 31, 2016 at 06:50:04AM -0600, Eric Blake wrote:
> On 05/31/2016 04:07 AM, Denis V. Lunev wrote:
> > The command will work this way:
> >     qemu-img create --trace qcow2* -f qcow2 1.img 64G
> > 
> > Signed-off-by: Denis V. Lunev <den@openvz.org>
> > Suggested by: Daniel P. Berrange <berrange@redhat.com>
> > CC: Eric Blake <eblake@redhat.com>
> > CC: Paolo Bonzini <pbonzini@redhat.com>
> > CC: Stefan Hajnoczi <stefanha@redhat.com>
> > CC: Kevin Wolf <kwolf@redhat.com>
> > ---
> >  qemu-img.c | 97 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> >  1 file changed, 96 insertions(+), 1 deletion(-)
> 
> Missing man page additions.
> 
> 
> > @@ -155,7 +157,12 @@ static void QEMU_NORETURN help(void)
> >             "Parameters to compare subcommand:\n"
> >             "  '-f' first image format\n"
> >             "  '-F' second image format\n"
> > -           "  '-s' run in Strict mode - fail on different image size or sector allocation\n";
> > +           "  '-s' run in Strict mode - fail on different image size or sector allocation\n"
> > +           "\n"
> > +           "General purpose options:\n"
> > +           "  -R, --trace [[enable=]<pattern>][,events=<file>][,file=<file>]\n"
> > +           "       specify tracing options\n"
> > +           "       see qemu(1) man page for full description\n";
> 
> Why -R? Because -T is already in use by rebase and compare?  I'd almost
> rather have _just_ --trace with no short option, than to pick yet
> another letter, but you might want to wait for other opinions first.

Agreed, I think it'd be fine to use --trace and skip the short option

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|