From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7lIk-0005aY-C3 for qemu-devel@nongnu.org; Tue, 31 May 2016 11:09:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7lIe-0007M3-KJ for qemu-devel@nongnu.org; Tue, 31 May 2016 11:09:50 -0400 Date: Tue, 31 May 2016 17:09:34 +0200 From: Igor Mammedov Message-ID: <20160531170934.11f9c49a@nial.brq.redhat.com> In-Reply-To: <1463663970-23661-1-git-send-email-imammedo@redhat.com> References: <1463663970-23661-1-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/6] acpi: simplify bios_linker API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: zhaoshenglong@huawei.com, qemu-arm@nongnu.org, mst@redhat.com On Thu, 19 May 2016 15:19:24 +0200 Igor Mammedov wrote: > Simplify bios_linker API by adding file name + blob tracking > so user would have to suppily less arguments which > reduces chances of mistake by using wrong blob pointer > with not related file. > And also refactor API to take file offsets, > which is what is usualy used in context of file APIs, > (and as it's what actually current API were doing only internally), > instead of using host pointers. > I hope it makes it easier for user to use API without > need to look at implementation in QEMU/SeaBIOS. ping > > > Igor Mammedov (6): > acpi: convert linker from GArray to BIOSLinker structure > acpi: simplify bios_linker API by removing redundant 'table' argument > acpi: cleanup bios_linker_loader_cleanup() > tpm: apci: cleanup TCPA table initialization > acpi: make bios_linker_loader_add_pointer() API offset based > acpi: make bios_linker_loader_add_checksum() API offset based > > hw/acpi/aml-build.c | 33 +++---- > hw/acpi/bios-linker-loader.c | 179 +++++++++++++++++++++-------------- > hw/acpi/nvdimm.c | 22 +++-- > hw/arm/virt-acpi-build.c | 56 +++++------ > hw/i386/acpi-build.c | 92 +++++++++--------- > include/hw/acpi/aml-build.h | 7 +- > include/hw/acpi/bios-linker-loader.h | 28 +++--- > include/hw/mem/nvdimm.h | 3 +- > 8 files changed, 235 insertions(+), 185 deletions(-) >