From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7tGU-0004WT-0k for qemu-devel@nongnu.org; Tue, 31 May 2016 19:40:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7tGR-0001Mp-Vi for qemu-devel@nongnu.org; Tue, 31 May 2016 19:40:00 -0400 Date: Tue, 31 May 2016 16:39:48 -0700 From: Stefan Hajnoczi Message-ID: <20160531233948.GA14713@stefanha-x1.localdomain> References: <1464607873-28206-1-git-send-email-pl@kamp.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CE+1k2dSO48ffgeK" Content-Disposition: inline In-Reply-To: <1464607873-28206-1-git-send-email-pl@kamp.de> Subject: Re: [Qemu-devel] [PATCH V3] block/io: optimize bdrv_co_pwritev for small requests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, famz@redhat.com, kwolf@redhat.com, mreitz@redhat.com, pbonzini@redhat.com --CE+1k2dSO48ffgeK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 30, 2016 at 01:31:13PM +0200, Peter Lieven wrote: > in a read-modify-write cycle a small request might cause > head and tail to fall into the same aligned block. Currently > QEMU reads the same block twice in this case which is > not necessary. >=20 > Signed-off-by: Peter Lieven > --- > v1->v2: following Paolos suggestions to simplify the if condition and > adjusting the comment > v2->v3: fix iotest 077 for requests that are within the same aligned bloc= k [Fam, Kevin] >=20 > block/io.c | 8 ++++++++ > tests/qemu-iotests/077 | 12 +----------- > tests/qemu-iotests/077.out | 26 -------------------------- > 3 files changed, 9 insertions(+), 37 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --CE+1k2dSO48ffgeK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXTiDEAAoJEJykq7OBq3PIg/wH/0ssTy/VseaTarA9EC2DZWB5 JCKpLMomsV0nbOD9bkzGDmajFPJVx8OUK+YTXXzraFYw4/SH4uebZ0ypMyb5HnKP I8PUVF8hiBBcAeSbtziw+OKD4pkJhIA2e8PytjC7WB+DD47WAxyBqpyOtpmyEv6P FD9e0EESgpimYgd3yyLYivkphEQj2dSDzAN904alzT/U9f4oY+Z2NAJ5XY8ua1z0 hGu8pDgtCpnZspCNn3gCsldV+I38xgcACER1uDssJ2GirmH8hDu+zycMBDQdQO9v ZJGGG2iEDnOjJXQTzcs/Zi0h3ehgzauFu32zH2jVUSgpHOY5CTtUnrM2AxVJT28= =maE5 -----END PGP SIGNATURE----- --CE+1k2dSO48ffgeK--