From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7vrQ-0005Qe-VI for qemu-devel@nongnu.org; Tue, 31 May 2016 22:26:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7vrL-0000y9-VN for qemu-devel@nongnu.org; Tue, 31 May 2016 22:26:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46684) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7vrL-0000y5-Pz for qemu-devel@nongnu.org; Tue, 31 May 2016 22:26:15 -0400 Date: Wed, 1 Jun 2016 10:26:12 +0800 From: Fam Zheng Message-ID: <20160601022612.GB8639@ad.usersys.redhat.com> References: <20160527135437.20474-1-famz@redhat.com> <20160527135437.20474-5-famz@redhat.com> <20160531110058.GA24019@ad.usersys.redhat.com> <56a9a421-be5a-2e81-c4d2-aa1d41219ff4@redhat.com> <20160531124002.GB25364@ad.usersys.redhat.com> <81bebb8b-25f8-26de-a3b5-d1f800534b46@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <81bebb8b-25f8-26de-a3b5-d1f800534b46@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 04/15] Makefile: Rules for docker testing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Alex =?iso-8859-1?Q?Benn=E9e?= On Tue, 05/31 14:48, Paolo Bonzini wrote: > > > On 31/05/2016 14:40, Fam Zheng wrote: > > > I'm still a bit undecided about the pollution introduced by > > > tests/docker/Makefile.include, but I guess that's okay. > > > > I think it's also okay to switch to "make -C tests/docker" for docker targets > > (so "make docker" becomes "make -C tests/docker help"), this way the top > > Makefile is not touched. > > That would be a bit harder to discover. Go ahead with your current > solution. Perhaps rename SRC_COPY to DOCKER_SRC_COPY? OK, good idea. Fam