From: Fam Zheng <famz@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org,
neil.williams@linaro.org, steve.mcintyre@linaro.org,
riku.voipio@linaro.org
Subject: Re: [Qemu-devel] [RFC PATCH 1/2] tests/docker/docker.py: support --qemu option
Date: Wed, 1 Jun 2016 11:00:45 +0800 [thread overview]
Message-ID: <20160601030045.GC8639@ad.usersys.redhat.com> (raw)
In-Reply-To: <87wpma6ykl.fsf@linaro.org>
On Tue, 05/31 16:23, Alex Bennée wrote:
> >> +def _find_user_binary(binary_name):
> >> + """ Find a binary in the QEMU source tree. Used for finding qemu-$arch."""
> >> + top = os.path.abspath("%s/../../.." % sys.argv[0])
> >
> > What if this is an out of tree build?
>
> Yes I kinda avoided the complexity here. Do we have a programatic way of
> finding this out or should we just assume we get based a resolvable path?
As said below, let's assume the user provides an absolute path or a relative
path against the working directory, so we don't need to worry about path
guessing. The script caller should have more information.
Fam
next prev parent reply other threads:[~2016-06-01 3:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 14:27 [Qemu-devel] [RFC PATCH 0/2] Support building qemu-user powered docker test images Alex Bennée
2016-05-26 14:27 ` [Qemu-devel] [RFC PATCH 1/2] tests/docker/docker.py: support --qemu option Alex Bennée
2016-05-27 11:28 ` Fam Zheng
2016-05-31 15:23 ` Alex Bennée
2016-06-01 3:00 ` Fam Zheng [this message]
2016-05-26 14:27 ` [Qemu-devel] [RFC PATCH 2/2] add debian-bootstrap.docker target Alex Bennée
2016-05-27 12:23 ` Fam Zheng
2016-05-31 15:27 ` Alex Bennée
2016-06-01 1:47 ` Fam Zheng
2016-06-01 4:27 ` [Qemu-devel] [RFC PATCH] docker: Support ".pre" script when building image Fam Zheng
2016-05-27 12:27 ` [Qemu-devel] [RFC PATCH 0/2] Support building qemu-user powered docker test images Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601030045.GC8639@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=neil.williams@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@linaro.org \
--cc=steve.mcintyre@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).