From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b82BE-0008Re-KZ for qemu-devel@nongnu.org; Wed, 01 Jun 2016 05:11:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b82B8-0004KK-Jh for qemu-devel@nongnu.org; Wed, 01 Jun 2016 05:11:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50657) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b82B8-0004KG-Dp for qemu-devel@nongnu.org; Wed, 01 Jun 2016 05:11:06 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D3819C0003FE for ; Wed, 1 Jun 2016 09:11:05 +0000 (UTC) Date: Wed, 1 Jun 2016 17:11:02 +0800 From: Fam Zheng Message-ID: <20160601091102.GH8639@ad.usersys.redhat.com> References: <1464707044-10447-1-git-send-email-lersek@redhat.com> <20160531151418.GZ21628@redhat.com> <20160531154346.GB21628@redhat.com> <8d55914d-e57c-43e3-5319-28db331de5f8@redhat.com> <574DCDB5.5000208@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] configure: save git working tree information in "pkgversion" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: Eric Blake , "Daniel P. Berrange" , qemu-devel@nongnu.org On Wed, 06/01 10:55, Laszlo Ersek wrote: > (Anyway, this is moot now; I'll happily leave it to Fam! :)) Thanks, I wrote the code before you sent this, so I posted it today anyway. :) Also note that we shouldn't do this at configure time, because between ./configure and make, the tree can be modified. That's why my patch is in Makefile, and always checks the "dirtiness". Fam