From: Fam Zheng <famz@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
qemu-block@nongnu.org, peter.maydell@linaro.org,
eblake@redhat.com, berrange@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/2] Let PKGVERSION include the "git describe" output
Date: Wed, 1 Jun 2016 17:12:23 +0800 [thread overview]
Message-ID: <20160601091223.GI8639@ad.usersys.redhat.com> (raw)
In-Reply-To: <f0e93991-bc26-1e29-c507-3cbf07fc5ce2@redhat.com>
On Wed, 06/01 10:49, Laszlo Ersek wrote:
> Some comments / questions on the version string:
> - What happens if "--with-pkgversion=blah" was passed to ./configure?
> Do I see it right that in that case there's no change in behavior?
Yes, Makefile only generates it when ./configure says it's empty.
>
> - I think the following format would look better (stolen from
> --with-pkgversion):
>
> 2.6.50 (v2.6.0-603-g684a494)
Great idea!
Fam
prev parent reply other threads:[~2016-06-01 9:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 4:41 [Qemu-devel] [PATCH v2 0/2] Let PKGVERSION include the "git describe" output Fam Zheng
2016-06-01 4:41 ` [Qemu-devel] [PATCH v2 1/2] Makefile: Add a "FORCE" target Fam Zheng
2016-06-01 4:41 ` [Qemu-devel] [PATCH v2 2/2] Makefile: Derive "PKGVERSION" from "git describe" by default Fam Zheng
2016-06-01 8:49 ` [Qemu-devel] [PATCH v2 0/2] Let PKGVERSION include the "git describe" output Laszlo Ersek
2016-06-01 9:12 ` Fam Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601091223.GI8639@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=lersek@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).