From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51979)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1b82CY-0001QW-OB
	for qemu-devel@nongnu.org; Wed, 01 Jun 2016 05:12:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1b82CX-0004Yf-Ps
	for qemu-devel@nongnu.org; Wed, 01 Jun 2016 05:12:34 -0400
Date: Wed, 1 Jun 2016 17:12:23 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160601091223.GI8639@ad.usersys.redhat.com>
References: <1464756079-13659-1-git-send-email-famz@redhat.com>
	<f0e93991-bc26-1e29-c507-3cbf07fc5ce2@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f0e93991-bc26-1e29-c507-3cbf07fc5ce2@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] Let PKGVERSION include the "git
 describe" output
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, qemu-block@nongnu.org, peter.maydell@linaro.org, eblake@redhat.com, berrange@redhat.com

On Wed, 06/01 10:49, Laszlo Ersek wrote:
> Some comments / questions on the version string:
> - What happens if "--with-pkgversion=blah" was passed to ./configure?
>   Do I see it right that in that case there's no change in behavior?

Yes, Makefile only generates it when ./configure says it's empty.

> 
> - I think the following format would look better (stolen from
>   --with-pkgversion):
> 
>   2.6.50 (v2.6.0-603-g684a494)

Great idea!

Fam