From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43510) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8J7E-0001dv-MG for qemu-devel@nongnu.org; Wed, 01 Jun 2016 23:16:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8J7C-0003Nt-K8 for qemu-devel@nongnu.org; Wed, 01 Jun 2016 23:16:11 -0400 Date: Thu, 2 Jun 2016 11:15:59 +0800 From: Fam Zheng Message-ID: <20160602031559.GG19448@ad.usersys.redhat.com> References: <1464764901-8773-1-git-send-email-weijg.fnst@cn.fujitsu.com> <20160601072326.GF8639@ad.usersys.redhat.com> <1464836600.5185.7.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1464836600.5185.7.camel@localhost> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] block/raw-posix: Fix error_report of mounting message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Wei, Jiangang" Cc: "kwolf@redhat.com" , "qemu-trivial@nongnu.org" , "qemu-devel@nongnu.org" , "qemu-block@nongnu.org" , "mreitz@redhat.com" On Thu, 06/02 03:04, Wei, Jiangang wrote: > On Wed, 2016-06-01 at 15:23 +0800, Fam Zheng wrote: > > On Wed, 06/01 15:08, Wei Jiangang wrote: > > > Use a single error_printf to replace triple error_report. > > >=20 > > > Signed-off-by: Wei Jiangang > > > --- > > > block/raw-posix.c | 10 +++++----- > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > >=20 > > > diff --git a/block/raw-posix.c b/block/raw-posix.c > > > index a4f5a1b..141b01a 100644 > > > --- a/block/raw-posix.c > > > +++ b/block/raw-posix.c > > > @@ -2061,11 +2061,11 @@ static bool setup_cdrom(char *bsd_path, Err= or **errp) > > > /* Prints directions on mounting and unmounting a device */ > > > static void print_unmounting_directions(const char *file_name) > > > { > > > - error_report("If device %s is mounted on the desktop, unmount" > > > - " it first before using it in QEMU", file_name); > > > - error_report("Command to unmount device: diskutil unmountDisk = %s", > > > - file_name); > > > - error_report("Command to mount device: diskutil mountDisk %s",= file_name); > > > + error_printf("If device %s is mounted on the desktop, unmount" > > > + " it first before using it in QEMU\n" > > > + "Command to unmount device: diskutil unmountDisk %s\n" > > > + "Command to mount device: diskutil mountDisk %s\n", > > > + file_name, file_name, file_name); > >=20 > > I'd say it's less readable with a worse alignment to the parameters. > Hi, Fam >=20 > Thanks for your comment. > You mean every error_report() followed by file_name is more readable ? > or my codes dosen't follow a good alignment format=EF=BC=9F >=20 I'm happy with either way. :) Fam