From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8J7T-0001ki-V0 for qemu-devel@nongnu.org; Wed, 01 Jun 2016 23:16:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8J7Q-0003Oz-1X for qemu-devel@nongnu.org; Wed, 01 Jun 2016 23:16:26 -0400 Date: Thu, 2 Jun 2016 13:17:52 +1000 From: David Gibson Message-ID: <20160602031752.GJ15455@voom.fritz.box> References: <1464655277-14748-1-git-send-email-david@gibson.dropbear.id.au> <1464655277-14748-5-git-send-email-david@gibson.dropbear.id.au> <574E1021.8040805@ilande.co.uk> <20160601021511.GA15455@voom.fritz.box> <574E88AC.7020608@ilande.co.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5cSRzy0VGBWAML+b" Content-Disposition: inline In-Reply-To: <574E88AC.7020608@ilande.co.uk> Subject: Re: [Qemu-devel] [Qemu-ppc] [PULL 04/12] ppc: tlbie, tlbia and tlbisync are HV only List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland Cc: peter.maydell@linaro.org, pbonzini@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, bharata.rao@gmail.com, clg@kaod.org --5cSRzy0VGBWAML+b Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 01, 2016 at 08:03:08AM +0100, Mark Cave-Ayland wrote: > On 01/06/16 03:15, David Gibson wrote: >=20 > > On Tue, May 31, 2016 at 11:28:49PM +0100, Mark Cave-Ayland wrote: > >> On 31/05/16 01:41, David Gibson wrote: > >> > >>> From: Benjamin Herrenschmidt > >>> > >>> Not that anything remotely recent supports tlbia but ... > >>> > >>> Signed-off-by: Benjamin Herrenschmidt > >>> Signed-off-by: David Gibson > >>> --- > >>> target-ppc/translate.c | 6 +++--- > >>> 1 file changed, 3 insertions(+), 3 deletions(-) > >>> > >>> diff --git a/target-ppc/translate.c b/target-ppc/translate.c > >>> index dfd3010..690ffd2 100644 > >>> --- a/target-ppc/translate.c > >>> +++ b/target-ppc/translate.c > >>> @@ -4858,7 +4858,7 @@ static void gen_tlbie(DisasContext *ctx) > >>> #if defined(CONFIG_USER_ONLY) > >>> gen_inval_exception(ctx, POWERPC_EXCP_PRIV_OPC); > >>> #else > >>> - if (unlikely(ctx->pr)) { > >>> + if (unlikely(ctx->pr || !ctx->hv)) { > >>> gen_inval_exception(ctx, POWERPC_EXCP_PRIV_OPC); > >>> return; > >>> } > >>> @@ -4879,7 +4879,7 @@ static void gen_tlbsync(DisasContext *ctx) > >>> #if defined(CONFIG_USER_ONLY) > >>> gen_inval_exception(ctx, POWERPC_EXCP_PRIV_OPC); > >>> #else > >>> - if (unlikely(ctx->pr)) { > >>> + if (unlikely(ctx->pr || !ctx->hv)) { > >>> gen_inval_exception(ctx, POWERPC_EXCP_PRIV_OPC); > >>> return; > >>> } > >>> @@ -4898,7 +4898,7 @@ static void gen_slbia(DisasContext *ctx) > >>> #if defined(CONFIG_USER_ONLY) > >>> gen_inval_exception(ctx, POWERPC_EXCP_PRIV_OPC); > >>> #else > >>> - if (unlikely(ctx->pr)) { > >>> + if (unlikely(ctx->pr || !ctx->hv)) { > >>> gen_inval_exception(ctx, POWERPC_EXCP_PRIV_OPC); > >>> return; > >>> } > >> > >> Unfortunately this patch breaks qemu-system-ppc for both g3beige and > >> mac99 under TCG causing a freeze in OpenBIOS when starting > >> qemu-system-ppc with no parameters. > >=20 > > Bother, sorry. > >=20 > > I think this is because I applied this without the patch that treats > > machines with no hypervisor mode (e.g. Apples) as always being in > > hypervisor mode. >=20 > No problem, I can cope for a couple of days or so. C=E9dric, Not sure if you've seen this thread, but one of the HV-mode patches caused a regression on Mac. I think it's because I didn't include the other patch which treats Apple-mode PPCs as always having HV=3D1. Can you make sending your updated version of that patch a priority, even if the rest of the batch of HV patches isn't ready yet. > >> Note that there is also another regression that has recently landed in > >> git master so you'll also need to revert > >> e7c9136977cb99c6eb52c9139f7b8d8b5fa87db9 in order to get back to a > >> functioning OpenBIOS. > >=20 > > I'd preter to see it fixed rather than just reverted.. >=20 > Looks like the original author has found the bug, so there should be a > fix coming up for this soon (I only included it here in case you needed > an explicit test case). Ok. So, yeah, I'm not really set up to test Mac machines which means I don't easily catch regressions like this. Mark, Could you look into adding a testcase to "make check" that will at least catch these unsubtle breaks boot type regressions? --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --5cSRzy0VGBWAML+b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXT6VgAAoJEGw4ysog2bOSanwQALGGOxZeBxZ5NuBp6CNaleU9 6jlttZQQ36PyX047HmPSDiAWJpLuhNWEo57K4SQbEOsr6OrwQDGMFAFjIvDxQyUS nnozjPe9DcTLj2hmdEKVSbdqeCAjoj3OJ1GntR7ROMiQXNRJHZzDP93JeEkfBndd 0/CfTh9Ll/HpLZgRqSMu7pqRmpZ4DkSX+Em8jXB2NqRClTcWeVeIpSyJRnAVDiTv 38MoNmR2wYgiODkSp/8NSdDB0H76wg8hxy4O1jSX1zfF7HHWo30UYZvsrlGcvV9b fu5iAKJeLMnmfLKHokld4b4G/k5ykcoWSs2ijn8KGj6U1jnnVzyRNK7CRq3vxbQc VvFINPDLbt9wRVqzrOIymDAzuv9jPxIq5o7EanGaOmFUJGsSu8QGK014zHISKlg0 C9U6haSIBNgwS5/Ps9L7VO70FMNWIqJY+iUKk8BMeJv2o+HvysCrzgShCeMarxwf lk90Fj0u4LoSNPjYz+kA9vC68Taol6MHsOIV+63Uc5itSpsNYUic42EVZhfr+Q34 2OHiWPH3axhBxIT8DxsJA+83bfGVLNR2xp38HDIkYg+XTsl1HZBqxWRgJm+D3OSS OAq7frRohV1l4jahbR9dQQhCBt2fa3OiDtwnB6ymg6gnouK05B9EriHpvD081jhR 9A2Wkw+WdYq7rgYy8BXE =994g -----END PGP SIGNATURE----- --5cSRzy0VGBWAML+b--