From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8PgN-0007Rd-Bn for qemu-devel@nongnu.org; Thu, 02 Jun 2016 06:16:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8PgH-0004rF-4y for qemu-devel@nongnu.org; Thu, 02 Jun 2016 06:16:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40534) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8PgG-0004rB-VW for qemu-devel@nongnu.org; Thu, 02 Jun 2016 06:16:49 -0400 Date: Thu, 2 Jun 2016 11:16:44 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20160602101643.GA4085@work-vm> References: <1460346962-10420-1-git-send-email-xiecl.fnst@cn.fujitsu.com> <1460346962-10420-2-git-send-email-xiecl.fnst@cn.fujitsu.com> <20160527155854.GF4456@grmbl.mre> <20160601172300.GD2310@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v4 1/1] Introduce "xen-load-devices-state" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: Changlong Xie , zhanghailiang , Stefano Stabellini , Juan Quintela , qemu devel , Markus Armbruster , Anthony PERARD , Amit Shah * Stefano Stabellini (sstabellini@kernel.org) wrote: > On Thu, 2 Jun 2016, Stefano Stabellini wrote: > > On Wed, 1 Jun 2016, Dr. David Alan Gilbert wrote: > > > * Amit Shah (amit.shah@redhat.com) wrote: > > > > Dave, can you take a look? > > > > > > Yes, I think I'm happy with it; > > > > > > Reviewed-by: Dr. David Alan Gilbert > > > > > > I think people might try interesting non-Xen things with it; for > > > example I think if you backed QEMU's main RAM by a /tmp file > > > perhaps you could start a guest up even under KVM just > > > by loading the devices. > > > > I added this patch to the Xen queue. > > I spoke too quickly. I get: > > /local/qemu/migration/savevm.c: In function 'qmp_xen_load_devices_state': > /local/qemu/migration/savevm.c:2089:5: error: implicit declaration of function 'qemu_fopen' [-Werror=implicit-function-declaration] > /local/qemu/migration/savevm.c:2089:5: error: nested extern declaration of 'qemu_fopen' [-Werror=nested-externs] > /local/qemu/migration/savevm.c:2089:7: error: assignment makes pointer from integer without a cast [-Werror] Ah, yes, your problem is that Dan's crypto changes have probably just removed that; see qmp_xen_save_devices_state and 8925839f that changed it to use the new qio_channel_file_new_path. Dave > CC i386-softmmu/hw/display/virtio-vga.o > cc1: all warnings being treated as errors -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK