Re: [Qemu-devel] [PATCH 0/4] 9p: get rid of readdir_r()

[Greg Kurz <gkurz@linux.vnet.ibm.com>]

On Thu, 2 Jun 2016 10:33:06 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:

> On 2 June 2016 at 09:51, Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:
> > The readdir_r() function has a broken design and should not be used anymore.
> > It is expected to be obsoleted in a future version of POSIX.1:
> >
> > http://austingroupbugs.net/view.php?id=696#c2857
> >
> > Glibc has already announced that 2.24 (scheduled for August 2016) will
> > deprecates readdir_r() and encourages people to use readdir() with
> > external synchronization instead.  
> 
> > Since POSIX.1 will require readdir() to be thread-safe when employed on
> > different directory streams, and glibc already does that, the choice
> > was made to have per-directory locking.  
> 
> AIUI the argument is that all sensible implementations of readdir()
> already provide the thread-safety guarantees POSIX is going to
> specify, but have you tested this on one of the BSDs or OSX?
> (and/or checked their current readdir implementation...)
> 

No I haven't because "VirtFS is supported only on Linux" at the moment.

But thanks for raising the flag: it reminds me that there's ongoing
work to support VirtFS on win32 hosts and I should also Cc Michael
Fritscher.

Thanks !

--
Greg

> thanks
> -- PMM
>